Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: base/allocator/allocator.gyp

Issue 2019183002: Restore the -fvisibility=hidden flag for tcmalloc when using allocator shim. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/allocator/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'target_defaults': { 6 'target_defaults': {
7 'variables': { 7 'variables': {
8 # This code gets run a lot and debugged rarely, so it should be fast 8 # This code gets run a lot and debugged rarely, so it should be fast
9 # by default. See http://crbug.com/388949. 9 # by default. See http://crbug.com/388949.
10 'debug_optimize': '2', 10 'debug_optimize': '2',
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 'sources!': [ 294 'sources!': [
295 '<(tcmalloc_dir)/src/system-alloc.h', 295 '<(tcmalloc_dir)/src/system-alloc.h',
296 ], 296 ],
297 # We enable all warnings by default, but upstream disables a few. 297 # We enable all warnings by default, but upstream disables a few.
298 # Keep "-Wno-*" flags in sync with upstream by comparing against: 298 # Keep "-Wno-*" flags in sync with upstream by comparing against:
299 # http://code.google.com/p/google-perftools/source/browse/trunk/Ma kefile.am 299 # http://code.google.com/p/google-perftools/source/browse/trunk/Ma kefile.am
300 'cflags': [ 300 'cflags': [
301 '-Wno-sign-compare', 301 '-Wno-sign-compare',
302 '-Wno-unused-result', 302 '-Wno-unused-result',
303 ], 303 ],
304 'cflags!': [
305 '-fvisibility=hidden',
306 ],
307 'link_settings': { 304 'link_settings': {
308 'ldflags': [ 305 'ldflags': [
309 # Don't let linker rip this symbol out, otherwise the heap&cpu 306 # Don't let linker rip this symbol out, otherwise the heap&cpu
310 # profilers will not initialize properly on startup. 307 # profilers will not initialize properly on startup.
311 '-Wl,-uIsHeapProfilerRunning,-uProfilerStart', 308 '-Wl,-uIsHeapProfilerRunning,-uProfilerStart',
312 # Do the same for heap leak checker. 309 # Do the same for heap leak checker.
313 '-Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_M MapPKvS0_jiiix,-u_Z22InitialMallocHook_SbrkPKvi', 310 '-Wl,-u_Z21InitialMallocHook_NewPKvj,-u_Z22InitialMallocHook_M MapPKvS0_jiiix,-u_Z22InitialMallocHook_SbrkPKvi',
314 '-Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_M MapPKvS0_miiil,-u_Z22InitialMallocHook_SbrkPKvl', 311 '-Wl,-u_Z21InitialMallocHook_NewPKvm,-u_Z22InitialMallocHook_M MapPKvS0_miiil,-u_Z22InitialMallocHook_SbrkPKvl',
315 '-Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakC hecker14UnIgnoreObjectEPKv', 312 '-Wl,-u_ZN15HeapLeakChecker12IgnoreObjectEPKv,-u_ZN15HeapLeakC hecker14UnIgnoreObjectEPKv',
316 ], 313 ],
317 }, 314 },
315 # Compiling tcmalloc with -fvisibility=default is only necessary w hen
316 # not using the allocator shim, which provides the correct visibil ity
317 # annotations for those symbols which need to be exported (see
318 # //base/allocator/allocator_shim_override_glibc_weak_symbols.h an d
319 # //base/allocator/allocator_shim_internals.h for the definition o f
320 # SHIM_ALWAYS_EXPORT).
321 'conditions': [
322 ['use_experimental_allocator_shim==0', {
323 'cflags!': [
324 '-fvisibility=hidden',
325 ],
326 }],
327 ],
318 }], 328 }],
319 ['profiling!=1', { 329 ['profiling!=1', {
320 'sources!': [ 330 'sources!': [
321 # cpuprofiler 331 # cpuprofiler
322 '<(tcmalloc_dir)/src/base/thread_lister.c', 332 '<(tcmalloc_dir)/src/base/thread_lister.c',
323 '<(tcmalloc_dir)/src/base/thread_lister.h', 333 '<(tcmalloc_dir)/src/base/thread_lister.h',
324 '<(tcmalloc_dir)/src/profile-handler.cc', 334 '<(tcmalloc_dir)/src/profile-handler.cc',
325 '<(tcmalloc_dir)/src/profile-handler.h', 335 '<(tcmalloc_dir)/src/profile-handler.h',
326 '<(tcmalloc_dir)/src/profiledata.cc', 336 '<(tcmalloc_dir)/src/profiledata.cc',
327 '<(tcmalloc_dir)/src/profiledata.h', 337 '<(tcmalloc_dir)/src/profiledata.h',
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 '-Wl,-wrap,valloc', 441 '-Wl,-wrap,valloc',
432 ], 442 ],
433 }, 443 },
434 }], 444 }],
435 ] 445 ]
436 }, # 'unified_allocator_shim' target. 446 }, # 'unified_allocator_shim' target.
437 ], 447 ],
438 }] 448 }]
439 ], 449 ],
440 } 450 }
OLDNEW
« no previous file with comments | « base/allocator/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698