Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2019163002: Make test.dart override only those dependencies declared in the pubspec.yaml (Closed)

Created:
4 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 6 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make test.dart override only those dependencies declared in the pubspec.yaml file (attempt #2). Differences from before: - pull in transitive dependencies that were missing - pass on the package-root in standalone/io/test_runner_test BUG= http://dartbug.com/26563 R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/d1d46593d583fa1c5be3596342d243ad8a2809c2

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -7 lines) Patch
M DEPS View 6 chunks +9 lines, -2 lines 0 comments Download
M pkg/pkgbuild.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
A tools/.packages View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 3 chunks +27 lines, -3 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
Siggi Cherem (dart-lang)
4 years, 6 months ago (2016-05-28 01:10:32 UTC) #8
Bill Hesse
lgtm
4 years, 6 months ago (2016-05-31 22:47:47 UTC) #9
Siggi Cherem (dart-lang)
4 years, 6 months ago (2016-05-31 22:49:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:60001) manually as
d1d46593d583fa1c5be3596342d243ad8a2809c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698