Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2019113002:
PPC: initializing array to fix compiler error maybe-uninitialized (Closed)
|
Created:
4 years, 6 months ago by JaideepBajwa Modified:
4 years, 6 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionPPC: initializing array to fix compiler error maybe-uninitialized
This error is specific to PPC on native(sim builds fine), seems
AddHexEncodedToBuffer is inlined (with -fno-inline it passes)
and the compiler emits error that the array may be used
uninitialized in this function.
I'm not entirely sure why this occurs only on PPC (native).
R=franzih@chromium.org, bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
BUG=
LOG=N
Committed: https://crrev.com/0e5c6a4bb9b3ff06e469ae437a292b1e94531d25
Cr-Commit-Position: refs/heads/master@{#36628}
Patch Set 1 #
Messages
Total messages: 20 (9 generated)
PTAL
Description was changed from
==========
PPC: initializing array to fix compiler error maybe-uninitialized
This error is specific to PPC on native(sim builds fine), seems
AddHexEncodedToBuffer is inlined (with -fno-inline it passes)
and the compiler emits error that the array may be used
uninitialized in this function.
I'm not entirely sure why this occurs only on PPC (native).
R=franzih@chromium.org, bmeurer@chromium.org, joransiu@ca.ibm.com,
jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
BUG=
LOG=N
==========
to
==========
PPC: initializing array to fix compiler error maybe-uninitialized
This error is specific to PPC on native(sim builds fine), seems
AddHexEncodedToBuffer is inlined (with -fno-inline it passes)
and the compiler emits error that the array may be used
uninitialized in this function.
I'm not entirely sure why this occurs only on PPC (native).
R=franzih@chromium.org, bmeurer@chromium.org, joransiu@ca.ibm.com,
jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
BUG=
LOG=N
==========
bjaideep@ca.ibm.com changed reviewers: + jyan@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com
Thanks! LGTM
The CQ bit was checked by franzih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019113002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by bjaideep@ca.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019113002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16194)
LGTM (rubber-stamped)
The CQ bit was checked by bmeurer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019113002/1
Message was sent while issue was closed.
Description was changed from
==========
PPC: initializing array to fix compiler error maybe-uninitialized
This error is specific to PPC on native(sim builds fine), seems
AddHexEncodedToBuffer is inlined (with -fno-inline it passes)
and the compiler emits error that the array may be used
uninitialized in this function.
I'm not entirely sure why this occurs only on PPC (native).
R=franzih@chromium.org, bmeurer@chromium.org, joransiu@ca.ibm.com,
jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
BUG=
LOG=N
==========
to
==========
PPC: initializing array to fix compiler error maybe-uninitialized
This error is specific to PPC on native(sim builds fine), seems
AddHexEncodedToBuffer is inlined (with -fno-inline it passes)
and the compiler emits error that the array may be used
uninitialized in this function.
I'm not entirely sure why this occurs only on PPC (native).
R=franzih@chromium.org, bmeurer@chromium.org, joransiu@ca.ibm.com,
jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
BUG=
LOG=N
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
PPC: initializing array to fix compiler error maybe-uninitialized
This error is specific to PPC on native(sim builds fine), seems
AddHexEncodedToBuffer is inlined (with -fno-inline it passes)
and the compiler emits error that the array may be used
uninitialized in this function.
I'm not entirely sure why this occurs only on PPC (native).
R=franzih@chromium.org, bmeurer@chromium.org, joransiu@ca.ibm.com,
jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
BUG=
LOG=N
==========
to
==========
PPC: initializing array to fix compiler error maybe-uninitialized
This error is specific to PPC on native(sim builds fine), seems
AddHexEncodedToBuffer is inlined (with -fno-inline it passes)
and the compiler emits error that the array may be used
uninitialized in this function.
I'm not entirely sure why this occurs only on PPC (native).
R=franzih@chromium.org, bmeurer@chromium.org, joransiu@ca.ibm.com,
jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
BUG=
LOG=N
Committed: https://crrev.com/0e5c6a4bb9b3ff06e469ae437a292b1e94531d25
Cr-Commit-Position: refs/heads/master@{#36628}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/0e5c6a4bb9b3ff06e469ae437a292b1e94531d25 Cr-Commit-Position: refs/heads/master@{#36628} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
