Chromium Code Reviews| Index: Source/core/page/ChromeClient.h |
| diff --git a/Source/core/page/ChromeClient.h b/Source/core/page/ChromeClient.h |
| index b95a1df41c40acfaddc1f164671d992d02471d35..e1ab7e29ced6883a67537c7ea84717d0759bcf7d 100644 |
| --- a/Source/core/page/ChromeClient.h |
| +++ b/Source/core/page/ChromeClient.h |
| @@ -125,12 +125,9 @@ public: |
| virtual void setResizable(bool) = 0; |
| - virtual void addMessageToConsole(MessageSource, MessageLevel, const String& message, unsigned lineNumber, const String& sourceID) = 0; |
| - // FIXME: Remove this MessageType variant once all the clients are updated. |
| - virtual void addMessageToConsole(MessageSource source, MessageType, MessageLevel level, const String& message, unsigned lineNumber, const String& sourceID) |
| - { |
| - addMessageToConsole(source, level, message, lineNumber, sourceID); |
| - } |
| + virtual bool shouldReportDetailedMessageForContext(v8::Handle<v8::Context>) = 0; |
|
yurys
2013/07/26 09:17:21
Are we fine with using v8 types in this API? Or sh
|
| + virtual bool shouldReportDetailedMessageForURL(const String&) = 0; |
| + virtual void addMessageToConsole(MessageSource, MessageLevel, const String& message, unsigned lineNumber, const String& sourceID, const String& details) = 0; |
| virtual bool canRunBeforeUnloadConfirmPanel() = 0; |
| virtual bool runBeforeUnloadConfirmPanel(const String& message, Frame*) = 0; |