Route JS Error Info From Blink to Chrome

Source/core/page/PageConsole.cpp

 /*
  * Copyright (C) 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 65 matching lines @@
 
 void PageConsole::addMessage(MessageSource source, MessageLevel level, const String& message, const String& url, unsigned lineNumber, unsigned columnNumber, PassRefPtr<ScriptCallStack> callStack, ScriptState* state, unsigned long requestIdentifier)
 {
     if (muteCount && source != ConsoleAPIMessageSource)
         return;
 
     Page* page = this->page();
     if (!page)
         return;
 
+    String executionContextURL = page->mainFrame()->document()->url().string();
+    bool reportDetailedMessage = (state && page->chrome().client()->shouldReportDetailedMessageForContext(state->context()))
+        || page->chrome().client()->shouldReportDetailedMessageForURL(url)
+        || page->chrome().client()->shouldReportDetailedMessageForURL(executionContextURL);
+
+    OwnPtr<ConsoleMessage> consoleMessage = callStack
+        ? adoptPtr(new ConsoleMessage(reportDetailedMessage, source, LogMessageType, level, message, executionContextURL, callStack, requestIdentifier))
+        : adoptPtr(new ConsoleMessage(reportDetailedMessage, source, LogMessageType, level, message, executionContextURL, url, lineNumber, columnNumber, state, requestIdentifier));

[abarth-chromium, 2013/07/24 23:59:09]

Can you extract some of this logic into a helper function?  This is a lot of
detailed work for this function.

[Devlin, 2013/07/25 01:46:00]

Done.

+
+    if (source != CSSMessageSource)
+        page->chrome().client()->addMessageToConsole(source, level, message, lineNumber, url, consoleMessage->generateJSONWithoutArguments()->toJSONString());
+
     if (callStack)
-        InspectorInstrumentation::addMessageToConsole(page, source, LogMessageType, level, message, callStack, requestIdentifier);
+        InspectorInstrumentation::addMessageToConsole(page, consoleMessage.release());
     else
-        InspectorInstrumentation::addMessageToConsole(page, source, LogMessageType, level, message, url, lineNumber, columnNumber, state, requestIdentifier);
-
-    if (source == CSSMessageSource)
-        return;
-
-    page->chrome().client()->addMessageToConsole(source, level, message, lineNumber, url);
+        InspectorInstrumentation::addMessageToConsole(page, consoleMessage.release(), true);
 }
 
 // static
 void PageConsole::mute()
 {
     muteCount++;
 }
 
 // static
 void PageConsole::unmute()
 {
     ASSERT(muteCount > 0);
     muteCount--;
 }
 
 } // namespace WebCore