Source/core/inspector/InspectorConsoleAgent.h - Issue 20191003: Route JS Error Info From Blink to Chrome

Side by Side Diff: Source/core/inspector/InspectorConsoleAgent.h

Issue 20191003: Route JS Error Info From Blink to Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@gclient

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 57 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
68 virtual void clearMessages(ErrorString*);	68 virtual void clearMessages(ErrorString*);

69 bool enabled() { return m_enabled; }	69 bool enabled() { return m_enabled; }

70 void reset();	70 void reset();

71	71

72 virtual void setFrontend(InspectorFrontend*);	72 virtual void setFrontend(InspectorFrontend*);

73 virtual void clearFrontend();	73 virtual void clearFrontend();

74 virtual void restore();	74 virtual void restore();

75	75

76 void addMessageToConsole(MessageSource, MessageType, MessageLevel, const Str ing& message, ScriptState*, PassRefPtr<ScriptArguments>, unsigned long requestId entifier = 0);	76 void addMessageToConsole(MessageSource, MessageType, MessageLevel, const Str ing& message, ScriptState*, PassRefPtr<ScriptArguments>, unsigned long requestId entifier = 0);

77 void addMessageToConsole(MessageSource, MessageType, MessageLevel, const Str ing& message, const String& scriptId, unsigned lineNumber, unsigned columnNumber = 0, ScriptState* = 0, unsigned long requestIdentifier = 0);	77 void addMessageToConsole(MessageSource, MessageType, MessageLevel, const Str ing& message, const String& scriptId, unsigned lineNumber, unsigned columnNumber = 0, ScriptState* = 0, unsigned long requestIdentifier = 0);

	78 void addMessageToConsole(PassOwnPtr<ConsoleMessage>, bool checkFrontend = fa lse);
	abarth-chromium 2013/07/24 23:59:09 Rather than adding a raw Boolean parameter, consid Rather than adding a raw Boolean parameter, consider adding an enum parameter so we can more easily tell what callers are doing. Devlin 2013/07/25 01:46:00 Done, but not sure I like the location (InspectorA Show quoted text On 2013/07/24 23:59:09, abarth wrote: > Rather than adding a raw Boolean parameter, consider adding an enum parameter so > we can more easily tell what callers are doing. Done, but not sure I like the location (InspectorAgent). Do you think it'd be better somewhere else?
78	79

79 // FIXME: Remove once we no longer generate stacks outside of Inspector.	80 // FIXME: Remove once we no longer generate stacks outside of Inspector.

80 void addMessageToConsole(MessageSource, MessageType, MessageLevel, const Str ing& message, PassRefPtr<ScriptCallStack>, unsigned long requestIdentifier = 0);	81 void addMessageToConsole(MessageSource, MessageType, MessageLevel, const Str ing& message, PassRefPtr<ScriptCallStack>, unsigned long requestIdentifier = 0);

81	82

82 Vector<unsigned> consoleMessageArgumentCounts();	83 Vector<unsigned> consoleMessageArgumentCounts();

83	84

84 void startConsoleTiming(Frame*, const String& title);	85 void startConsoleTiming(Frame*, const String& title);

85 void stopConsoleTiming(Frame*, const String& title, PassRefPtr<ScriptCallSta ck>);	86 void stopConsoleTiming(Frame*, const String& title, PassRefPtr<ScriptCallSta ck>);

86 void consoleCount(ScriptState*, PassRefPtr<ScriptArguments>);	87 void consoleCount(ScriptState*, PassRefPtr<ScriptArguments>);

87	88

(...skipping 23 matching lines...) Expand all Loading...
111 HashMap<String, double> m_times;	112 HashMap<String, double> m_times;

112 bool m_enabled;	113 bool m_enabled;

113 private:	114 private:

114 static int s_enabledAgentCount;	115 static int s_enabledAgentCount;

115 };	116 };

116	117

117 } // namespace WebCore	118 } // namespace WebCore

118	119

119	120

120 #endif // !defined(InspectorConsoleAgent_h)	121 #endif // !defined(InspectorConsoleAgent_h)

OLD	NEW