Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2019073002: Move forceSRGB to SkCommonFlags (Closed)

Created:
4 years, 6 months ago by herb_g
Modified:
4 years, 6 months ago
Reviewers:
kjlubick
CC:
mtklein, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move forceSRGB to SkCommonFlags. This fixes a duplicate symbol problem with the iOS build. Add common forceSRGB flag. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2019073002 Committed: https://skia.googlesource.com/skia/+/ca1ec03c5c8db26e07a931415e9592d8e1966da0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M bench/nanobench.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M dm/DM.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/flags/SkCommonFlags.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019073002/1
4 years, 6 months ago (2016-05-27 17:44:17 UTC) #3
kjlubick
lgtm
4 years, 6 months ago (2016-05-27 17:47:30 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 17:56:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019073002/1
4 years, 6 months ago (2016-05-27 17:57:07 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 17:58:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ca1ec03c5c8db26e07a931415e9592d8e1966da0

Powered by Google App Engine
This is Rietveld 408576698