Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Issue 2019013002: mus: Send display-id to client only for the root windows. (Closed)

Created:
4 years, 6 months ago by sadrul
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Send display-id to client only for the root windows. Child windows are always in the same display as their parent windows, so it doesn't make sense to always send the display-id for each window created. Instead, notify the client about the display each root-window is on, and have the client be responsible for tracking that for each child window afterwards. BUG=603316 Committed: https://crrev.com/33b39373f9270fed89e53cd658bb3001f2e05849 Cr-Commit-Position: refs/heads/master@{#396511}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : mojom-format #

Total comments: 2

Patch Set 4 : doc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -30 lines) Patch
M components/mus/public/cpp/lib/window.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 7 chunks +6 lines, -3 lines 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_private.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 1 2 3 3 chunks +9 lines, -4 lines 0 comments Download
M components/mus/ws/test_utils.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/mus/ws/test_utils.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree.cc View 5 chunks +7 lines, -12 lines 0 comments Download
M components/mus/ws/window_tree_client_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sadrul
4 years, 6 months ago (2016-05-27 15:30:40 UTC) #2
sadrul
+tsepez@ for window_tree.mojom
4 years, 6 months ago (2016-05-27 15:31:16 UTC) #4
sky
LGTM https://codereview.chromium.org/2019013002/diff/40001/components/mus/public/interfaces/window_tree.mojom File components/mus/public/interfaces/window_tree.mojom (right): https://codereview.chromium.org/2019013002/diff/40001/components/mus/public/interfaces/window_tree.mojom#newcode289 components/mus/public/interfaces/window_tree.mojom:289: int64 display_id, Document what display_id means here and ...
4 years, 6 months ago (2016-05-27 16:25:56 UTC) #5
sadrul
https://codereview.chromium.org/2019013002/diff/40001/components/mus/public/interfaces/window_tree.mojom File components/mus/public/interfaces/window_tree.mojom (right): https://codereview.chromium.org/2019013002/diff/40001/components/mus/public/interfaces/window_tree.mojom#newcode289 components/mus/public/interfaces/window_tree.mojom:289: int64 display_id, On 2016/05/27 16:25:56, sky wrote: > Document ...
4 years, 6 months ago (2016-05-27 16:37:28 UTC) #6
Tom Sepez
lgtm
4 years, 6 months ago (2016-05-27 16:52:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019013002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019013002/60001
4 years, 6 months ago (2016-05-27 17:21:59 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-05-27 18:07:10 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 18:10:45 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/33b39373f9270fed89e53cd658bb3001f2e05849
Cr-Commit-Position: refs/heads/master@{#396511}

Powered by Google App Engine
This is Rietveld 408576698