Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: chrome/browser/media_galleries/fileapi/media_file_validator_unittest.cc

Issue 20190002: Add a copy or move validator to that can handle support audio and video files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: to dcheck Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/media_file_validator_unittest.cc
diff --git a/chrome/browser/media_galleries/fileapi/media_file_validator_unittest.cc b/chrome/browser/media_galleries/fileapi/media_file_validator_unittest.cc
deleted file mode 100644
index 5fde5e470667666c5452b29b3abdc16bdba854f5..0000000000000000000000000000000000000000
--- a/chrome/browser/media_galleries/fileapi/media_file_validator_unittest.cc
+++ /dev/null
@@ -1,228 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/basictypes.h"
-#include "base/bind.h"
-#include "base/file_util.h"
-#include "base/files/file_path.h"
-#include "base/files/scoped_temp_dir.h"
-#include "base/message_loop/message_loop.h"
-#include "base/message_loop/message_loop_proxy.h"
-#include "chrome/browser/media_galleries/fileapi/media_file_system_backend.h"
-#include "chrome/test/base/in_process_browser_test.h"
-#include "content/public/test/browser_test.h"
-#include "content/public/test/test_utils.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "webkit/browser/fileapi/copy_or_move_file_validator.h"
-#include "webkit/browser/fileapi/file_system_backend.h"
-#include "webkit/browser/fileapi/file_system_context.h"
-#include "webkit/browser/fileapi/file_system_operation_runner.h"
-#include "webkit/browser/fileapi/file_system_url.h"
-#include "webkit/browser/fileapi/isolated_context.h"
-#include "webkit/browser/fileapi/mock_file_system_context.h"
-#include "webkit/browser/fileapi/test_file_system_backend.h"
-#include "webkit/common/fileapi/file_system_types.h"
-
-namespace {
-
-const char kOrigin[] = "http://foo";
-
-const char kValidImage[] = "RIFF0\0\0\0WEBPVP8 $\0\0\0\xB2\x02\0\x9D\x01\x2A"
- "\x01\0\x01\0\x2F\x9D\xCE\xE7s\xA8((((\x01\x9CK(\0"
- "\x05\xCE\xB3l\0\0\xFE\xD8\x80\0\0";
-
-const char kInvalidImage[] = "Not an image";
-
-const int64 kNoFileSize = -1;
-
-void HandleCheckFileResult(int64 expected_size,
- const base::Callback<void(bool success)>& callback,
- base::PlatformFileError result,
- const base::PlatformFileInfo& file_info) {
- if (result == base::PLATFORM_FILE_OK) {
- if (!file_info.is_directory && expected_size != kNoFileSize &&
- file_info.size == expected_size) {
- callback.Run(true);
- return;
- }
- } else {
- if (expected_size == kNoFileSize) {
- callback.Run(true);
- return;
- }
- }
- callback.Run(false);
-}
-
-} // namespace
-
-namespace chrome {
-
-class MediaFileValidatorTest : public InProcessBrowserTest {
- public:
- MediaFileValidatorTest() : test_file_size_(0) {}
-
- virtual ~MediaFileValidatorTest() {}
-
- // Write |content| into |filename| in a test file system and try to move
- // it into a media file system. The result is compared to |expected_result|.
- void MoveTest(const std::string& filename, const std::string& content,
- bool expected_result) {
- content::BrowserThread::PostTask(
- content::BrowserThread::FILE,
- FROM_HERE,
- base::Bind(&MediaFileValidatorTest::SetupOnFileThread,
- base::Unretained(this), filename, content, expected_result));
- loop_runner_ = new content::MessageLoopRunner;
- loop_runner_->Run();
- }
-
- private:
- // Create the test files, filesystem objects, etc.
- void SetupOnFileThread(const std::string& filename,
- const std::string& content,
- bool expected_result) {
- ASSERT_TRUE(base_dir_.CreateUniqueTempDir());
- base::FilePath base = base_dir_.path();
- base::FilePath src_path = base.AppendASCII("src_fs");
- ASSERT_TRUE(file_util::CreateDirectory(src_path));
-
- ScopedVector<fileapi::FileSystemBackend> additional_providers;
- additional_providers.push_back(new fileapi::TestFileSystemBackend(
- base::MessageLoopProxy::current().get(), src_path));
- additional_providers.push_back(new MediaFileSystemBackend(
- base, base::MessageLoopProxy::current().get()));
- file_system_context_ =
- fileapi::CreateFileSystemContextWithAdditionalProvidersForTesting(
- NULL, additional_providers.Pass(), base);
-
- move_src_ = file_system_context_->CreateCrackedFileSystemURL(
- GURL(kOrigin), fileapi::kFileSystemTypeTest,
- base::FilePath::FromUTF8Unsafe(filename));
-
- test_file_size_ = content.size();
- base::FilePath test_file = src_path.AppendASCII(filename);
- ASSERT_EQ(test_file_size_,
- file_util::WriteFile(test_file, content.data(), test_file_size_));
-
- base::FilePath dest_path = base.AppendASCII("dest_fs");
- ASSERT_TRUE(file_util::CreateDirectory(dest_path));
- std::string dest_fsid =
- fileapi::IsolatedContext::GetInstance()->RegisterFileSystemForPath(
- fileapi::kFileSystemTypeNativeMedia, dest_path, NULL);
-
- size_t extension_index = filename.find_last_of(".");
- ASSERT_NE(std::string::npos, extension_index);
- std::string extension = filename.substr(extension_index);
- std::string dest_root_fs_url = fileapi::GetIsolatedFileSystemRootURIString(
- GURL(kOrigin), dest_fsid, "dest_fs/");
- move_dest_ = file_system_context_->CrackURL(GURL(
- dest_root_fs_url + "move_dest" + extension));
-
- content::BrowserThread::PostTask(
- content::BrowserThread::IO,
- FROM_HERE,
- base::Bind(&MediaFileValidatorTest::CheckFiles,
- base::Unretained(this), true,
- base::Bind(&MediaFileValidatorTest::OnTestFilesReady,
- base::Unretained(this), expected_result)));
- }
-
- // Check that exactly one of |move_src_| and |move_dest_| exists.
- // |src_expected| indicates which one should exist. When complete,
- // |callback| is called with success/failure.
- void CheckFiles(bool src_expected,
- const base::Callback<void(bool success)>& callback) {
- CheckFile(move_src_, src_expected ? test_file_size_ : kNoFileSize,
- base::Bind(&MediaFileValidatorTest::OnCheckFilesFirstResult,
- base::Unretained(this), !src_expected, callback));
- }
-
- // Helper that checks a file has the |expected_size|, which may be
- // |kNoFileSize| if the file should not exist. |callback| is called
- // with success/failure.
- void CheckFile(fileapi::FileSystemURL url,
- int64 expected_size,
- const base::Callback<void(bool success)>& callback) {
- operation_runner()->GetMetadata(url,
- base::Bind(&HandleCheckFileResult,
- expected_size, callback));
- }
-
- // Helper that checks the result of |move_src_| lookup and then checks
- // |move_dest_| if all is as expected.
- void OnCheckFilesFirstResult(bool dest_expected,
- const base::Callback<void(bool)>& callback,
- bool src_result) {
- EXPECT_TRUE(src_result);
- if (!src_result) {
- callback.Run(false);
- return;
- }
- CheckFile(move_dest_, dest_expected ? test_file_size_ : kNoFileSize,
- callback);
- }
-
- // Assert |test_files_ready| and then do the actual test of moving
- // |move_src_| to |move_dest_|.
- void OnTestFilesReady(bool expected_result, bool test_files_ready) {
- ASSERT_TRUE(test_files_ready);
- operation_runner()->Move(
- move_src_, move_dest_,
- base::Bind(&MediaFileValidatorTest::OnMoveResult,
- base::Unretained(this), expected_result));
- }
-
- // Check that the move succeeded/failed based on expectation and then
- // check that the right file exists.
- void OnMoveResult(bool expected_result, base::PlatformFileError result) {
- if (expected_result)
- EXPECT_EQ(base::PLATFORM_FILE_OK, result);
- else
- EXPECT_EQ(base::PLATFORM_FILE_ERROR_SECURITY, result);
- CheckFiles(!expected_result,
- base::Bind(&MediaFileValidatorTest::OnTestFilesCheckResult,
- base::Unretained(this)));
- }
-
- // Check that the correct test file exists and then post the result back
- // to the UI thread.
- void OnTestFilesCheckResult(bool result) {
- EXPECT_TRUE(result);
- content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
- loop_runner_->QuitClosure());
- }
-
- fileapi::FileSystemOperationRunner* operation_runner() {
- return file_system_context_->operation_runner();
- }
-
- base::ScopedTempDir base_dir_;
-
- scoped_refptr<fileapi::FileSystemContext> file_system_context_;
-
- int test_file_size_;
-
- fileapi::FileSystemURL move_src_;
- fileapi::FileSystemURL move_dest_;
-
- scoped_refptr<content::MessageLoopRunner> loop_runner_;
-
- DISALLOW_COPY_AND_ASSIGN(MediaFileValidatorTest);
-};
-
-IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, ValidImage) {
- MoveTest("a.webp", std::string(kValidImage, arraysize(kValidImage)), true);
-}
-
-IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, InvalidImage) {
- MoveTest("a.webp", std::string(kInvalidImage, arraysize(kInvalidImage)),
- false);
-}
-
-IN_PROC_BROWSER_TEST_F(MediaFileValidatorTest, UnsupportedExtension) {
- MoveTest("a.txt", std::string(kValidImage, arraysize(kValidImage)), false);
-}
-
-} // namespace chrome

Powered by Google App Engine
This is Rietveld 408576698