chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc - Issue 20190002: Add a copy or move validator to that can handle support audio and video files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc

Issue 20190002: Add a copy or move validator to that can handle support audio and video files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix test file name Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/fileapi/supported_audio_video_checker.cc ('K') | « chrome/browser/media_galleries/fileapi/supported_image_type_validator.h ('k') | chrome/browser_tests.isolate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc

diff --git a/chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc b/chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc

index 9ae76253c3bb4db6d4584970202449ed06684405..a377da6f056398849d1c541b2fd5c75861b2210b 100644

--- a/chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc

+++ b/chrome/browser/media_galleries/fileapi/supported_image_type_validator.cc

@@ -120,13 +120,9 @@ void SupportedImageTypeValidator::StartPostWriteValidation(

const base::FilePath& dest_platform_path,

const ResultCallback& result_callback) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

- post_write_callback_ = result_callback;

// TODO(gbillock): Insert AV call here in the right validator.

- BrowserThread::PostTask(

- BrowserThread::IO,

- FROM_HERE,

- base::Bind(post_write_callback_, base::PLATFORM_FILE_OK));

+ result_callback.Run(base::PLATFORM_FILE_OK);

Lei Zhang 2013/08/08 00:08:02 Need to rebase now that https://codereview.chromiu

vandebo (ex-Chrome) 2013/08/08 17:34:01 Done.

}

SupportedImageTypeValidator::SupportedImageTypeValidator(