chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc - Issue 20190002: Add a copy or move validator to that can handle support audio and video files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc

Issue 20190002: Add a copy or move validator to that can handle support audio and video files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix test file name Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc ('K') | « chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc ('k') | chrome/browser/media_galleries/fileapi/media_file_validator_unittest.cc » ('j') | chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc

diff --git a/chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc b/chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc

index e1804605784630a6a922dde19b5639eae34f10ba..ead22c16e632306a962061b469a20b88eafc3b0c 100644

--- a/chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc

+++ b/chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc

@@ -6,6 +6,7 @@

#include "base/files/file_path.h"

#include "base/platform_file.h"

+#include "chrome/browser/media_galleries/fileapi/supported_audio_video_checker.h"

#include "chrome/browser/media_galleries/fileapi/supported_image_type_validator.h"

#include "webkit/browser/fileapi/copy_or_move_file_validator.h"

#include "webkit/browser/fileapi/file_system_url.h"

@@ -50,7 +51,8 @@ MediaFileValidatorFactory::CreateCopyOrMoveFileValidator(

base::FilePath src_path = src.virtual_path();

if (SupportedImageTypeValidator::SupportsFileType(src_path))

return new SupportedImageTypeValidator(platform_path);

- // TODO(vandebo): Support other file types.

+ if (SupportedAudioVideoChecker::SupportsFileType(src_path))

+ return new SupportedAudioVideoChecker(platform_path);

return new InvalidFileValidator();

}