Add a copy or move validator to that can handle support audio and video files.

chrome/browser/media_galleries/fileapi/safe_audio_video_checker.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/media_galleries/fileapi/safe_audio_video_checker.h"
+
+#include "base/bind.h"
+#include "base/callback.h"
+#include "base/location.h"
+#include "base/logging.h"
+#include "base/process/process_handle.h"
+#include "chrome/common/chrome_utility_messages.h"
+#include "content/public/browser/child_process_data.h"

[Lei Zhang, 2013/08/08 00:08:02]

not needed?

[vandebo (ex-Chrome), 2013/08/08 17:34:01]

It is, used on line 59 on this patch set and
content/public/browser/utility_process_host.h only forward declares it.

+#include "content/public/browser/utility_process_host.h"
+#include "content/public/browser/browser_thread.h"
+#include "ipc/ipc_message_macros.h"
+#include "ipc/ipc_platform_file.h"
+
+SafeAudioVideoChecker::SafeAudioVideoChecker(
+    const base::PlatformFile& file,
+    const fileapi::CopyOrMoveFileValidator::ResultCallback& callback)
+    : state_(INITIAL_STATE),
+      file_(file),
+      file_closer_(&file_),
+      callback_(callback) {
+  DCHECK(!callback.is_null());
+}
+
+void SafeAudioVideoChecker::Start() {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+  if (state_ != INITIAL_STATE)
+    return;
+  state_ = PINGED_STATE;
+
+  if (*file_closer_ && *file_closer_.get() == base::kInvalidPlatformFileValue) {

[Lei Zhang, 2013/08/08 00:08:02]

*file_closer_ can't be NULL

[vandebo (ex-Chrome), 2013/08/08 17:34:01]

It can be... *file_closer_ <=> file_closer_.get(), which is a PlatformFile*. 
file_closer_.reset() will make *file_closer_ NULL

[Lei Zhang, 2013/08/08 18:18:07]

But nobody calls file_closer_.reset() except the dtor, right?

[vandebo (ex-Chrome), 2013/08/08 23:14:11]

SafeAudioVideoChecker::OnProcessStarted() calls files_closer_.release()

[Lei Zhang, 2013/08/08 23:16:21]

After that, the |state_| check makes sure we'll never get here.

[vandebo (ex-Chrome), 2013/08/08 23:18:24]

In the current version of the code, yes.

[Lei Zhang, 2013/08/09 01:01:33]

Then remove the check? Adjust accordingly if the code changes in the future.

[vandebo (ex-Chrome), 2013/08/09 04:11:09]

I'd rather leave it in.  It doesn't cost much, is somewhat subtle and brings the
check to the place where it's important instead of having the check far removed
from the thing needing the check.

+    callback_.Run(base::PLATFORM_FILE_ERROR_SECURITY);
+    state_ = FINISHED_STATE;
+    return;
+  }
+
+  utility_process_host_ = content::UtilityProcessHost::Create(
+      this, base::MessageLoopProxy::current())->AsWeakPtr();
+  utility_process_host_->EnableZygote();
+  utility_process_host_->Send(new ChromeUtilityMsg_StartupPing);
+}
+
+SafeAudioVideoChecker::~SafeAudioVideoChecker() {}
+
+void SafeAudioVideoChecker::OnProcessStarted() {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+  if (state_ != PINGED_STATE)
+    return;
+  state_ = STARTED_STATE;
+
+  if (utility_process_host_->GetData().handle == base::kNullProcessHandle)
+    DLOG(ERROR) << "Child process handle is null";
+  IPC::PlatformFileForTransit file_for_transit =
+      IPC::GetFileHandleForProcess(*file_closer_.release(),
+                                   utility_process_host_->GetData().handle,
+                                   true /* close_source_handle */);
+  const int64 kFileDecodeTimeInMS = 250;
+  utility_process_host_->Send(new ChromeUtilityMsg_CheckMediaFile(
+      kFileDecodeTimeInMS, file_for_transit));
+}
+
+void SafeAudioVideoChecker::OnCheckingFinished(bool valid) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+  if (state_ != STARTED_STATE)
+    return;
+  state_ = FINISHED_STATE;
+
+  callback_.Run(valid ? base::PLATFORM_FILE_OK
+                      : base::PLATFORM_FILE_ERROR_SECURITY);
+}
+
+void SafeAudioVideoChecker::OnProcessCrashed(int exit_code) {
+  OnCheckingFinished(false);
+}
+
+bool SafeAudioVideoChecker::OnMessageReceived(const IPC::Message& message) {
+  bool handled = true;
+  IPC_BEGIN_MESSAGE_MAP(SafeAudioVideoChecker, message)
+    IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ProcessStarted,
+        OnProcessStarted)
+    IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_CheckMediaFile_Finished,
+        OnCheckingFinished)
+    IPC_MESSAGE_UNHANDLED(handled = false)
+  IPC_END_MESSAGE_MAP()
+  return handled;
+}