Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2018973002: [libfuzzer] Add 'vptr' flag to builds with UndefinedBehaviourSanitizer. (Closed)

Created:
4 years, 6 months ago by mmoroz
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[libfuzzer] Add 'vptr' flag to builds with UndefinedBehaviourSanitizer. security_blacklist.txt is a merge of blacklist.txt and vptr_blacklist.txt. BUG=609786 Committed: https://crrev.com/16e7bcd3b68643a269fcec6163f18b16d97234bc Cr-Commit-Position: refs/heads/master@{#397090}

Patch Set 1 #

Patch Set 2 : Blacklisting of third_party/libc++abi/trunk/src/private_typeinfo.cpp. #

Patch Set 3 : Add ubsan_security to gyp config. #

Total comments: 1

Patch Set 4 : Fix a typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -10 lines) Patch
M build/common.gypi View 1 2 3 8 chunks +35 lines, -5 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/config/sanitizers/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A + tools/ubsan/security_blacklist.txt View 1 2 chunks +80 lines, -0 lines 0 comments Download
M tools/ubsan/vptr_blacklist.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
inferno
lgtm. Can you update the blacklist path in gyp config as well. see https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&l=500. otherwise ...
4 years, 6 months ago (2016-05-30 20:16:43 UTC) #4
mmoroz
On 2016/05/30 20:16:43, inferno wrote: > lgtm. > > Can you update the blacklist path ...
4 years, 6 months ago (2016-05-31 14:10:29 UTC) #5
inferno
lgtm
4 years, 6 months ago (2016-05-31 14:53:45 UTC) #6
aizatsky
lgtm
4 years, 6 months ago (2016-05-31 18:47:00 UTC) #7
Dirk Pranke
lgtm w/ typo fixed. https://codereview.chromium.org/2018973002/diff/40001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/2018973002/diff/40001/build/common.gypi#newcode4311 build/common.gypi:4311: ['asan==1 or lsan==1 or tsan==1 ...
4 years, 6 months ago (2016-05-31 18:50:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018973002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018973002/60001
4 years, 6 months ago (2016-06-01 08:06:02 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-01 09:27:46 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 09:29:11 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/16e7bcd3b68643a269fcec6163f18b16d97234bc
Cr-Commit-Position: refs/heads/master@{#397090}

Powered by Google App Engine
This is Rietveld 408576698