[builtins] Migrate String.prototype.trim/trimLeft/trimRight to C++.

[builtins] Migrate String.prototype.trim/trimLeft/trimRight to C++.

These builtins do call into C++ anyways, so there's no point in keeping
the JavaScript wrappers for them.

R=franzih@chromium.org
BUG=v8:5049
Committed: https://crrev.com/c3ffc92d4dca26786e5dc391e6289940fbb3ed0b
Cr-Commit-Position: refs/heads/master@{#36553}

[Benedikt Meurer, 2016-05-27 12:07:24]

Hey Franziska,

Here's a String CL for you :-)
Please take a look.

Thanks,
Benedikt

[Franzi, 2016-05-27 14:20:08]

LGTM

https://codereview.chromium.org/2018963002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/2018963002/diff/1/src/builtins.cc#newcode4558
src/builtins.cc:4558: BUILTIN(StringPrototypeTrim) {
This file is already very large (or so I was told :) ) Would it make sense to
move the - although short - implementations and macro to a separate file? Or
should I do that when I clean up strings.js?

https://codereview.chromium.org/2018963002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2018963002/diff/1/src/objects.cc#newcode9989
src/objects.cc:9989: // Flatten the input {string}.
Do we need this comment?

https://codereview.chromium.org/2018963002/diff/1/src/objects.cc#newcode9996
src/objects.cc:9996: if (mode & kTrimLeft) {
For readability, I would prefer

if (mode == kTrimLeft || mode == kTrim) {...}

Expecting a certain relationship between the values seems unnecessary to me.
Then we don't need the initializers in the enum declaration. 
enum TrimMode {
  kTrimLeft,
  kTrimRight,
  kTrim
};

[Benedikt Meurer, 2016-05-27 17:20:58]

https://codereview.chromium.org/2018963002/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/2018963002/diff/1/src/builtins.cc#newcode4558
src/builtins.cc:4558: BUILTIN(StringPrototypeTrim) {
Yes, builtins.cc should definitely be split at some point. But we couldn't reach
agreement on the how yet.

https://codereview.chromium.org/2018963002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2018963002/diff/1/src/objects.cc#newcode9989
src/objects.cc:9989: // Flatten the input {string}.
On 2016/05/27 14:20:08, Franzi wrote:
> Do we need this comment?

Done.

https://codereview.chromium.org/2018963002/diff/1/src/objects.cc#newcode9996
src/objects.cc:9996: if (mode & kTrimLeft) {
Good suggestion, thanks. Did that.

[Benedikt Meurer, 2016-05-27 17:21:03]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-05-27 17:21:03]

The patchset sent to the CQ was uploaded after l-g-t-m from franzih@chromium.org
Link to the patchset: https://codereview.chromium.org/2018963002/#ps20001
(title: "Address Franziskas comments.")

[commit-bot: I haz the power, 2016-05-27 17:21:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018963002/20001

[commit-bot: I haz the power, 2016-05-27 17:48:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-27 17:49:59]

Description was changed from

==========
[builtins] Migrate String.prototype.trim/trimLeft/trimRight to C++.

These builtins do call into C++ anyways, so there's no point in keeping
the JavaScript wrappers for them.

R=franzih@chromium.org
BUG=v8:5049
==========

to

==========
[builtins] Migrate String.prototype.trim/trimLeft/trimRight to C++.

These builtins do call into C++ anyways, so there's no point in keeping
the JavaScript wrappers for them.

R=franzih@chromium.org
BUG=v8:5049

Committed: https://crrev.com/c3ffc92d4dca26786e5dc391e6289940fbb3ed0b
Cr-Commit-Position: refs/heads/master@{#36553}
==========

[commit-bot: I haz the power, 2016-05-27 17:50:00]

Patchset 2 (id:??) landed as
https://crrev.com/c3ffc92d4dca26786e5dc391e6289940fbb3ed0b
Cr-Commit-Position: refs/heads/master@{#36553}