src/gpu/vk/GrVkStencilAttachment.cpp - Issue 2018933004: Add offset to memory allocations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkStencilAttachment.cpp

Issue 2018933004: Add offset to memory allocations (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/vk/GrVkStencilAttachment.cpp

diff --git a/src/gpu/vk/GrVkStencilAttachment.cpp b/src/gpu/vk/GrVkStencilAttachment.cpp

index 5976811be4618799a2171413c57bc14f7a998279..0343504afc1342fbb666b80bef0000904a0b1214 100644

--- a/src/gpu/vk/GrVkStencilAttachment.cpp

+++ b/src/gpu/vk/GrVkStencilAttachment.cpp

@@ -53,8 +53,7 @@ GrVkStencilAttachment* GrVkStencilAttachment::Create(GrVkGpu* gpu,

format.fInternalFormat,

GrVkImageView::kStencil_Type, 1);

if (!imageView) {

- VK_CALL(gpu, DestroyImage(gpu->device(), info.fImage, nullptr));

- VK_CALL(gpu, FreeMemory(gpu->device(), info.fAlloc, nullptr));

+ GrVkImage::DestroyImageInfo(gpu, &info);

return nullptr;

}