Roll PDFium 490d612..800222e

Roll PDFium 490d612..800222e

https://pdfium.googlesource.com/pdfium.git/+log/490d612..800222e

TBR=ochang@chromium.org

Committed: https://crrev.com/7bc6fd9ed40bf5c02bf61d6c21bfd521e76cdd3d
Cr-Commit-Position: refs/heads/master@{#396419}

[Lei Zhang, 2016-05-27 05:17:40]

Description was changed from

==========
Roll PDFium 490d612..800222e

https://pdfium.googlesource.com/pdfium.git/+log/490d612..800222e

BUG=

TEST=bots
==========

to

==========
Roll PDFium 490d612..800222e

https://pdfium.googlesource.com/pdfium.git/+log/490d612..800222e

TBR=ochang@chromium.org
==========

[Lei Zhang, 2016-05-27 05:17:40]

thestig@chromium.org changed reviewers:
+ ochang@chromium.org

[Lei Zhang, 2016-05-27 05:20:12]

TBR, 3 more commits vs https://codereview.chromium.org/2016163002/

[Oliver Chang, 2016-05-27 05:23:29]

lgtm

[Lei Zhang, 2016-05-27 06:58:26]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-05-27 06:58:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018903002/1

[commit-bot: I haz the power, 2016-05-27 07:39:04]

Description was changed from

==========
Roll PDFium 490d612..800222e

https://pdfium.googlesource.com/pdfium.git/+log/490d612..800222e

TBR=ochang@chromium.org
==========

to

==========
Roll PDFium 490d612..800222e

https://pdfium.googlesource.com/pdfium.git/+log/490d612..800222e

TBR=ochang@chromium.org
==========

[commit-bot: I haz the power, 2016-05-27 07:39:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-27 07:40:29]

Description was changed from

==========
Roll PDFium 490d612..800222e

https://pdfium.googlesource.com/pdfium.git/+log/490d612..800222e

TBR=ochang@chromium.org
==========

to

==========
Roll PDFium 490d612..800222e

https://pdfium.googlesource.com/pdfium.git/+log/490d612..800222e

TBR=ochang@chromium.org

Committed: https://crrev.com/7bc6fd9ed40bf5c02bf61d6c21bfd521e76cdd3d
Cr-Commit-Position: refs/heads/master@{#396419}
==========

[commit-bot: I haz the power, 2016-05-27 07:40:31]

Patchset 1 (id:??) landed as
https://crrev.com/7bc6fd9ed40bf5c02bf61d6c21bfd521e76cdd3d
Cr-Commit-Position: refs/heads/master@{#396419}

[stevenjb, 2016-05-27 15:51:57]

On 2016/05/27 07:40:31, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/7bc6fd9ed40bf5c02bf61d6c21bfd521e76cdd3d
> Cr-Commit-Position: refs/heads/master@{#396419}

We probably need to revert this, it is causing failures on chromeos:
https://build.chromium.org/p/chromiumos.chromium/builders/x86-generic-tot-chr...

First I am going to try to check whether this will revert cleanly and whether
there is an easy toolchain fix since it didn't appear in simple chrome.

[stevenjb, 2016-05-27 16:18:17]

On 2016/05/27 15:51:57, stevenjb wrote:
> On 2016/05/27 07:40:31, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/7bc6fd9ed40bf5c02bf61d6c21bfd521e76cdd3d
> > Cr-Commit-Position: refs/heads/master@{#396419}
> 
> We probably need to revert this, it is causing failures on chromeos:
>
https://build.chromium.org/p/chromiumos.chromium/builders/x86-generic-tot-chr...
> 
> First I am going to try to check whether this will revert cleanly and whether
> there is an easy toolchain fix since it didn't appear in simple chrome.

I was able to reproduce the error in Simple Chrome (with board = x86-generic)
using GYP (but it does not appear to fail with GN).

Unfortunately we need to revert this for now.

Filed http://crbug.com/615424 to track the toolchain discrepancy. 

Here is the failure snippet:

chromeos-chrome-53.0.2751.0_alpha-r1: [79/19620] CXX
obj/third_party/pdfium/xfa/fxfa/app/xfa.xfa_textlayout.o
chromeos-chrome-53.0.2751.0_alpha-r1: FAILED: i686-pc-linux-gnu-g++
-B/usr/x86_64-pc-linux-gnu/i686-pc-linux-gnu/binutils-bin/2.25.51-gold -MMD -MF
obj/third_party/pdfium/xfa/fxfa/app/xfa.xfa_textlayout.o.d -DPDF_ENABLE_XFA
-DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1
-DUSE_CAIRO=1 -DUSE_CRAS=1 -DUSE_OZONE=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_LIBJPEG_TURBO=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_WEBRTC=1
-DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS
-DENABLE_WAYLAND_SERVER=1 -DUSE_UDEV -DFIELDTRIAL_TESTING_ENABLED
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_PRINTING=1
-DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
-DSAFE_BROWSING_DB_LOCAL -DFT2_BUILD_LIBRARY -DUSE_LIBPCI=1 -DUSE_NSS_CERTS=1
-DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen
-I../../../../../../../home/chrome-bot/chrome_root/src
-I../../../../../../../home/chrome-bot/chrome_root/src/third_party/pdfium
-I../../../../../../../home/chrome-bot/chrome_root/src/third_party/pdfium/third_party/freetype/include
-I../../../../../../../home/chrome-bot/chrome_root/src/third_party/pdfium/third_party/freetype/include/freetype
-I../../../../../../../home/chrome-bot/chrome_root/src/v8
-I../../../../../../../home/chrome-bot/chrome_root/src/v8/include -Werror
-pthread -fno-strict-aliasing -Wall -Wno-extra -Wno-unused-parameter
-Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC
-Wno-unused-local-typedefs -Wno-error=strict-overflow -msse2 -mfpmath=sse -mmmx
-m32 --sysroot=/build/x86-generic -O2 -fno-ident -fdata-sections
-ffunction-sections -funwind-tables -gsplit-dwarf -march=i686 -pipe -march=i686
-pipe -pipe -march=i686 -mfpmath=sse -mmmx -msse -msse2 -msse3
-D__google_stl_debug_vector=1 -Wno-unknown-warning-option -fno-exceptions
-fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11
-Wno-narrowing -Wno-literal-suffix  -c
../../../../../../../home/chrome-bot/chrome_root/src/third_party/pdfium/xfa/fxfa/app/xfa_textlayout.cpp
-o obj/third_party/pdfium/xfa/fxfa/app/xfa.xfa_textlayout.o
chromeos-chrome-53.0.2751.0_alpha-r1: In file included from
../../../../../../../home/chrome-bot/chrome_root/src/third_party/pdfium/core/fxge/include/fx_dib.h:12:0,
chromeos-chrome-53.0.2751.0_alpha-r1:                  from
../../../../../../../home/chrome-bot/chrome_root/src/third_party/pdfium/xfa/fde/css/fde_css.h:10,
chromeos-chrome-53.0.2751.0_alpha-r1:                  from
../../../../../../../home/chrome-bot/chrome_root/src/third_party/pdfium/xfa/fxfa/app/xfa_textlayout.h:13,
chromeos-chrome-53.0.2751.0_alpha-r1:                  from
../../../../../../../home/chrome-bot/chrome_root/src/third_party/pdfium/xfa/fxfa/app/xfa_textlayout.cpp:7:
chromeos-chrome-53.0.2751.0_alpha-r1:
../../../../../../../home/chrome-bot/chrome_root/src/third_party/pdfium/core/fxcrt/include/fx_basic.h:
In member function 'void CXFA_TextLayout::ItemBlocks(const CFX_RectF&,
int32_t)':
chromeos-chrome-53.0.2751.0_alpha-r1:
../../../../../../../home/chrome-bot/chrome_root/src/third_party/pdfium/core/fxcrt/include/fx_basic.h:229:5:
warning: assuming signed overflow does not occur when assuming that (X - c) > X
is always false [-Wstrict-overflow]
chromeos-chrome-53.0.2751.0_alpha-r1:      if (nIndex < 0 || nIndex >= m_nSize)
{
chromeos-chrome-53.0.2751.0_alpha-r1:      ^
chromeos-chrome-53.0.2751.0_alpha-r1: At global scope:
chromeos-chrome-53.0.2751.0_alpha-r1: cc1plus: error: unrecognized command line
option "-Wno-unknown-warning-option" [-Werror]
chromeos-chrome-53.0.2751.0_alpha-r1: cc1plus: all warnings being treated as
errors
chromeos-chrome-53.0.2751.0_alpha-r1:

[stevenjb, 2016-05-27 16:19:34]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2017073002/ by stevenjb@chromium.org.

The reason for reverting is: Compile failures on chromeos:
https://build.chromium.org/p/chromiumos.chromium/builders/x86-generic-tot-chr...

See comment for details.
.

[Lei Zhang, 2016-05-27 18:08:09]

On 2016/05/27 15:51:57, stevenjb wrote:
> First I am going to try to check whether this will revert cleanly and whether
> there is an easy toolchain fix since it didn't appear in simple chrome.

BTW, PDFium rolls usually revert cleanly.