Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Side by Side Diff: cc/trees/property_tree_builder.cc

Issue 2018833002: cc : Delete LayerImpl::opacity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/property_tree_builder.h" 5 #include "cc/trees/property_tree_builder.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 643 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 654
655 static inline int NumDescendantsThatDrawContent(LayerImpl* layer) { 655 static inline int NumDescendantsThatDrawContent(LayerImpl* layer) {
656 return layer->test_properties()->num_descendants_that_draw_content; 656 return layer->test_properties()->num_descendants_that_draw_content;
657 } 657 }
658 658
659 static inline float EffectiveOpacity(Layer* layer) { 659 static inline float EffectiveOpacity(Layer* layer) {
660 return layer->EffectiveOpacity(); 660 return layer->EffectiveOpacity();
661 } 661 }
662 662
663 static inline float EffectiveOpacity(LayerImpl* layer) { 663 static inline float EffectiveOpacity(LayerImpl* layer) {
664 return layer->test_properties()->hide_layer_and_subtree ? 0.f 664 return layer->test_properties()->hide_layer_and_subtree
665 : layer->opacity(); 665 ? 0.f
666 : layer->test_properties()->opacity;
667 }
668
669 static inline float Opacity(Layer* layer) {
670 return layer->opacity();
671 }
672
673 static inline float Opacity(LayerImpl* layer) {
674 return layer->test_properties()->opacity;
666 } 675 }
667 676
668 static inline bool HideLayerAndSubtree(Layer* layer) { 677 static inline bool HideLayerAndSubtree(Layer* layer) {
669 return layer->hide_layer_and_subtree(); 678 return layer->hide_layer_and_subtree();
670 } 679 }
671 680
672 static inline bool HideLayerAndSubtree(LayerImpl* layer) { 681 static inline bool HideLayerAndSubtree(LayerImpl* layer) {
673 return layer->test_properties()->hide_layer_and_subtree; 682 return layer->test_properties()->hide_layer_and_subtree;
674 } 683 }
675 684
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
816 return false; 825 return false;
817 } 826 }
818 827
819 EffectNode node; 828 EffectNode node;
820 node.owner_id = layer->id(); 829 node.owner_id = layer->id();
821 if (AlwaysUseActiveTreeOpacity(layer)) { 830 if (AlwaysUseActiveTreeOpacity(layer)) {
822 data_for_children->property_trees->always_use_active_tree_opacity_effect_ids 831 data_for_children->property_trees->always_use_active_tree_opacity_effect_ids
823 .push_back(node.owner_id); 832 .push_back(node.owner_id);
824 } 833 }
825 834
826 node.data.opacity = layer->opacity(); 835 node.data.opacity = Opacity(layer);
827 node.data.has_render_surface = should_create_render_surface; 836 node.data.has_render_surface = should_create_render_surface;
828 node.data.has_copy_request = layer->HasCopyRequest(); 837 node.data.has_copy_request = layer->HasCopyRequest();
829 node.data.has_background_filters = !layer->background_filters().IsEmpty(); 838 node.data.has_background_filters = !layer->background_filters().IsEmpty();
830 node.data.has_potential_opacity_animation = has_potential_opacity_animation; 839 node.data.has_potential_opacity_animation = has_potential_opacity_animation;
831 node.data.double_sided = DoubleSided(layer); 840 node.data.double_sided = DoubleSided(layer);
832 node.data.subtree_hidden = HideLayerAndSubtree(layer); 841 node.data.subtree_hidden = HideLayerAndSubtree(layer);
833 node.data.is_currently_animating_opacity = layer->OpacityIsAnimating(); 842 node.data.is_currently_animating_opacity = layer->OpacityIsAnimating();
834 843
835 if (!is_root) { 844 if (!is_root) {
836 // The effect node's transform id is used only when we create a render 845 // The effect node's transform id is used only when we create a render
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
1277 if (SkColorGetA(color) != 255) 1286 if (SkColorGetA(color) != 255)
1278 color = SkColorSetA(color, 255); 1287 color = SkColorSetA(color, 255);
1279 BuildPropertyTreesTopLevelInternal( 1288 BuildPropertyTreesTopLevelInternal(
1280 root_layer, page_scale_layer, inner_viewport_scroll_layer, 1289 root_layer, page_scale_layer, inner_viewport_scroll_layer,
1281 outer_viewport_scroll_layer, overscroll_elasticity_layer, 1290 outer_viewport_scroll_layer, overscroll_elasticity_layer,
1282 elastic_overscroll, page_scale_factor, device_scale_factor, viewport, 1291 elastic_overscroll, page_scale_factor, device_scale_factor, viewport,
1283 device_transform, property_trees, color); 1292 device_transform, property_trees, color);
1284 } 1293 }
1285 1294
1286 } // namespace cc 1295 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698