Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2018823002: Eliminate WindowTreeConnection (Closed)

Created:
4 years, 7 months ago by Ben Goodger (Google)
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, kalyank, sadrul, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@connection
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate WindowTreeConnection BUG= Committed: https://crrev.com/f9da376cebae4df62d1e4a3fad9879d9f75b95fd Cr-Commit-Position: refs/heads/master@{#396861}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Total comments: 1

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+961 lines, -3766 lines) Patch
M components/mus/demo/mus_demo.h View 4 chunks +4 lines, -5 lines 0 comments Download
M components/mus/demo/mus_demo.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M components/mus/public/cpp/BUILD.gn View 1 2 3 4 5 6 7 8 9 2 chunks +5 lines, -6 lines 0 comments Download
M components/mus/public/cpp/input_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/in_flight_change.h View 1 2 7 chunks +10 lines, -12 lines 0 comments Download
M components/mus/public/cpp/lib/in_flight_change.cc View 1 2 3 chunks +9 lines, -11 lines 0 comments Download
M components/mus/public/cpp/lib/scoped_window_ptr.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/public/cpp/lib/window.cc View 1 2 3 4 5 22 chunks +80 lines, -85 lines 0 comments Download
M components/mus/public/cpp/lib/window_private.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + components/mus/public/cpp/lib/window_tree_client.cc View 1 2 3 4 5 6 7 8 9 59 chunks +109 lines, -143 lines 0 comments Download
A + components/mus/public/cpp/lib/window_tree_client_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D components/mus/public/cpp/lib/window_tree_client_impl.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -338 lines 0 comments Download
D components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1138 lines 0 comments Download
D components/mus/public/cpp/lib/window_tree_delegate.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_host_factory.cc View 1 1 chunk +6 lines, -8 lines 0 comments Download
M components/mus/public/cpp/tests/BUILD.gn View 1 2 3 4 5 6 7 8 9 2 chunks +5 lines, -5 lines 0 comments Download
A components/mus/public/cpp/tests/test_window_tree_client_setup.h View 1 1 chunk +53 lines, -0 lines 0 comments Download
A components/mus/public/cpp/tests/test_window_tree_client_setup.cc View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
M components/mus/public/cpp/tests/test_window_tree_connection_setup.h View 1 1 chunk +0 lines, -54 lines 0 comments Download
M components/mus/public/cpp/tests/test_window_tree_connection_setup.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.h View 1 6 chunks +14 lines, -14 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.cc View 1 2 5 chunks +11 lines, -13 lines 0 comments Download
D components/mus/public/cpp/tests/window_tree_client_impl_private.h View 1 chunk +0 lines, -47 lines 0 comments Download
D components/mus/public/cpp/tests/window_tree_client_impl_private.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -47 lines 0 comments Download
D components/mus/public/cpp/tests/window_tree_client_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1054 lines 0 comments Download
A components/mus/public/cpp/tests/window_tree_client_private.h View 1 chunk +47 lines, -0 lines 0 comments Download
A + components/mus/public/cpp/tests/window_tree_client_private.cc View 1 2 3 4 5 6 7 8 9 2 chunks +10 lines, -10 lines 0 comments Download
A + components/mus/public/cpp/tests/window_tree_client_unittest.cc View 1 2 3 4 5 6 7 8 9 42 chunks +83 lines, -84 lines 0 comments Download
M components/mus/public/cpp/window.h View 1 2 6 chunks +9 lines, -12 lines 0 comments Download
A + components/mus/public/cpp/window_tree_client.h View 1 2 3 4 5 6 7 8 9 10 chunks +61 lines, -38 lines 0 comments Download
A + components/mus/public/cpp/window_tree_client_delegate.h View 4 chunks +16 lines, -16 lines 0 comments Download
A components/mus/public/cpp/window_tree_client_observer.h View 1 chunk +27 lines, -0 lines 0 comments Download
D components/mus/public/cpp/window_tree_connection.h View 1 chunk +0 lines, -108 lines 0 comments Download
D components/mus/public/cpp/window_tree_connection_observer.h View 1 chunk +0 lines, -27 lines 0 comments Download
D components/mus/public/cpp/window_tree_delegate.h View 1 chunk +0 lines, -65 lines 0 comments Download
M components/mus/public/cpp/window_tree_host_factory.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/mus/test_wm/test_wm.cc View 1 2 3 4 5 6 7 8 9 5 chunks +7 lines, -10 lines 0 comments Download
M components/mus/ws/window_manager_client_unittest.cc View 1 2 3 4 5 6 7 8 9 36 chunks +106 lines, -109 lines 0 comments Download
M components/mus/ws/window_tree_client_unittest.cc View 1 2 3 4 5 6 7 8 9 11 chunks +22 lines, -22 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mus.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.h View 1 4 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/mus/compositor_mus_connection.cc View 1 3 chunks +5 lines, -7 lines 0 comments Download
M mash/browser/browser.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M mash/example/common/mus_views_init.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M mash/webtest/webtest.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/bridge/wm_globals_mus.h View 1 2 3 4 5 3 chunks +8 lines, -8 lines 0 comments Download
M mash/wm/bridge/wm_globals_mus.cc View 1 2 3 4 5 5 chunks +15 lines, -15 lines 0 comments Download
M mash/wm/bridge/wm_root_window_controller_mus.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/bridge/wm_window_mus.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M mash/wm/frame/non_client_frame_view_mash.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mash/wm/frame/non_client_frame_view_mash.cc View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
M mash/wm/root_window_controller.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M mash/wm/root_window_controller.cc View 1 2 3 4 5 6 7 8 9 4 chunks +9 lines, -11 lines 0 comments Download
M mash/wm/shadow_controller.h View 1 chunk +6 lines, -6 lines 0 comments Download
M mash/wm/shadow_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/test/wm_test_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/test/wm_test_base.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/test/wm_test_helper.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mash/wm/test/wm_test_helper.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/user_window_controller_impl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M mash/wm/user_window_controller_impl.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M mash/wm/window_manager.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager_unittest.cc View 1 2 4 chunks +26 lines, -24 lines 0 comments Download
M services/navigation/view_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M services/navigation/view_impl.cc View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -5 lines 0 comments Download
M ui/views/mus/native_widget_mus.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 3 4 5 6 7 8 9 4 chunks +6 lines, -7 lines 0 comments Download
M ui/views/mus/native_widget_mus_unittest.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +4 lines, -4 lines 0 comments Download
M ui/views/mus/surface_binding.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/surface_binding.cc View 1 2 3 4 5 6 7 8 9 4 chunks +39 lines, -41 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 2 3 4 5 6 7 8 9 8 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 29 (16 generated)
Ben Goodger (Google)
4 years, 6 months ago (2016-05-27 19:39:35 UTC) #2
sky
LGTM https://codereview.chromium.org/2018823002/diff/80001/components/mus/public/cpp/lib/window.cc File components/mus/public/cpp/lib/window.cc (right): https://codereview.chromium.org/2018823002/diff/80001/components/mus/public/cpp/lib/window.cc#newcode176 components/mus/public/cpp/lib/window.cc:176: window_tree()->DestroyWindow(this); window_tree() -> client_
4 years, 6 months ago (2016-05-27 20:45:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018823002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018823002/120001
4 years, 6 months ago (2016-05-27 21:30:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/237118)
4 years, 6 months ago (2016-05-27 21:52:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018823002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018823002/140001
4 years, 6 months ago (2016-05-27 22:49:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/237169)
4 years, 6 months ago (2016-05-27 23:07:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018823002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018823002/160001
4 years, 6 months ago (2016-05-27 23:13:20 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/101772) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 6 months ago (2016-05-27 23:32:01 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018823002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018823002/180001
4 years, 6 months ago (2016-05-31 16:31:02 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/102442)
4 years, 6 months ago (2016-05-31 16:52:57 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018823002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018823002/200001
4 years, 6 months ago (2016-05-31 16:56:14 UTC) #26
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 6 months ago (2016-05-31 18:06:25 UTC) #27
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 18:08:18 UTC) #29
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/f9da376cebae4df62d1e4a3fad9879d9f75b95fd
Cr-Commit-Position: refs/heads/master@{#396861}

Powered by Google App Engine
This is Rietveld 408576698