Improve diagnostic message for wrong gclient config

Improve diagnostic message for wrong gclient config

BUG=591814
TEST=gclient sync prints the correct report locally
when config is wrong.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300671

[levarum, 2016-05-26 23:39:50]

levarum@chromium.org changed reviewers:
+ hinoka@chromium.org, iannucci@chromium.org, stevenjb@chromium.org,
tandrii@chromium.org

[levarum, 2016-05-26 23:39:51]

PTAL

[stevenjb, 2016-05-27 01:33:16]

https://codereview.chromium.org/2018803002/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/2018803002/diff/1/gclient_scm.py#newcode193
gclient_scm.py:193: actual_remote_url =
self._get_first_remote_url(mirror.mirror_path)
indent incorrect?

[levarum, 2016-05-27 03:01:41]

https://codereview.chromium.org/2018803002/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/2018803002/diff/1/gclient_scm.py#newcode193
gclient_scm.py:193: actual_remote_url =
self._get_first_remote_url(mirror.mirror_path)
On 2016/05/27 01:33:16, stevenjb wrote:
> indent incorrect?

Done.

[stevenjb, 2016-05-27 03:06:33]

I'm not really familiar with this code, but lgtm.

[levarum, 2016-05-27 17:39:38]

The CQ bit was checked by levarum@chromium.org

[commit-bot: I haz the power, 2016-05-27 17:39:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018803002/20001

[commit-bot: I haz the power, 2016-05-27 17:39:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 17:39:49]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[levarum, 2016-05-27 17:44:05]

It appears I need L-G-T-M from project-infra-committers.
Can someone PTAL or suggest bettwer reviewers?

[hinoka, 2016-05-27 17:47:11]

https://codereview.chromium.org/2018803002/diff/20001/gclient.py
File gclient.py (right):

https://codereview.chromium.org/2018803002/diff/20001/gclient.py#newcode1237
gclient.py:1237: if (mirror):
no need for parens

https://codereview.chromium.org/2018803002/diff/20001/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/2018803002/diff/20001/gclient_scm.py#newcode176
gclient_scm.py:176: def GetCacheMirror(self):
I think you'll need to add a placeholder for SVN also

[levarum, 2016-05-27 18:02:21]

PTAL

https://codereview.chromium.org/2018803002/diff/20001/gclient.py
File gclient.py (right):

https://codereview.chromium.org/2018803002/diff/20001/gclient.py#newcode1237
gclient.py:1237: if (mirror):
On 2016/05/27 17:47:10, hinoka wrote:
> no need for parens

Done.

https://codereview.chromium.org/2018803002/diff/20001/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/2018803002/diff/20001/gclient_scm.py#newcode176
gclient_scm.py:176: def GetCacheMirror(self):
On 2016/05/27 17:47:11, hinoka wrote:
> I think you'll need to add a placeholder for SVN also

It should work for SVN as well (currently returning None).

SCM specific is hidden under the definition of cache_dir (which is currently
defined for GIT only) and url preprocessing (cutting url scm prefix if exists).

If not these specifics I would rather move this function to gclient_utils.py

[hinoka, 2016-05-28 00:17:26]

lgtm

[levarum, 2016-05-28 00:18:31]

The CQ bit was checked by levarum@chromium.org

[levarum, 2016-05-28 00:18:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2018803002/#ps40001
(title: "Fix parens")

[commit-bot: I haz the power, 2016-05-28 00:18:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018803002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018803002/40001

[commit-bot: I haz the power, 2016-05-28 00:21:50]

Description was changed from

==========
Improve diagnostic message for wrong gclient config

BUG=591814
TEST=gclient sync prints the correct report locally
when config is wrong.
==========

to

==========
Improve diagnostic message for wrong gclient config

BUG=591814
TEST=gclient sync prints the correct report locally
when config is wrong.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300671
==========

[commit-bot: I haz the power, 2016-05-28 00:21:51]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300671