Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2018773002: libsampler: Cleanup SamplerManager (Closed)

Created:
4 years, 7 months ago by alph
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, fmeawad
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

libsampler: Cleanup SamplerManager - Move the samplers related part out of SignalHandler class (remove friendship). - Make the SamplerManager class a singleton. - Minor tweaks. BUG=v8:4789 Committed: https://crrev.com/8b47179b14bb4ed64ceac275584f65fec704bda7 Cr-Commit-Position: refs/heads/master@{#36596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -68 lines) Patch
M src/libsampler/v8-sampler.cc View 12 chunks +62 lines, -68 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018773002/1
4 years, 7 months ago (2016-05-26 22:49:59 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-26 23:19:56 UTC) #4
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-26 23:20:04 UTC) #5
alph
Yang, could you please take a look.
4 years, 7 months ago (2016-05-26 23:22:27 UTC) #7
lpy
lgtm
4 years, 7 months ago (2016-05-27 05:47:37 UTC) #8
Yang
On 2016/05/27 05:47:37, lpy wrote: > lgtm lgtm.
4 years, 6 months ago (2016-05-30 13:06:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018773002/1
4 years, 6 months ago (2016-05-30 15:51:18 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 16:19:15 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 16:21:49 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b47179b14bb4ed64ceac275584f65fec704bda7
Cr-Commit-Position: refs/heads/master@{#36596}

Powered by Google App Engine
This is Rietveld 408576698