Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2018683002: Fix icon for Site Settings Site List. (Closed)

Created:
4 years, 7 months ago by Finnur
Modified:
4 years, 6 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix icon for Site Settings Site List. Wasn't being drawn (it was referring to the wrong package). BUG=599667, 589630 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/acdd8952437b03d69151e183134e5268a33a1ea3 Cr-Commit-Position: refs/heads/master@{#396349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/site_settings/site_list.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
Finnur
Feel free to check CQ box if this look alright.
4 years, 7 months ago (2016-05-26 21:25:18 UTC) #4
dschuyler
lgtm
4 years, 7 months ago (2016-05-26 21:26:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018683002/1
4 years, 7 months ago (2016-05-26 21:32:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/28562)
4 years, 7 months ago (2016-05-26 23:37:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018683002/1
4 years, 6 months ago (2016-05-27 00:38:08 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 01:49:25 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 01:50:26 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acdd8952437b03d69151e183134e5268a33a1ea3
Cr-Commit-Position: refs/heads/master@{#396349}

Powered by Google App Engine
This is Rietveld 408576698