Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2018673003: Fix for issue 26511 (VM hangs waiting for all threads that are not already at (Closed)

Created:
4 years, 6 months ago by siva
Modified:
4 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue 26511 (VM hangs waiting for all threads that are not already at a safepoint to check-in) BUG=26511 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/79e4792dd609ef2bb1f66588a912e420bc058709

Patch Set 1 #

Patch Set 2 : self-review-comments #

Total comments: 6

Patch Set 3 : code-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -32 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 2 29 chunks +42 lines, -22 lines 0 comments Download
M runtime/vm/lockers.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/safepoint.h View 1 2 1 chunk +36 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 6 months ago (2016-05-27 19:36:37 UTC) #2
rmacnak
lgtm w/c https://codereview.chromium.org/2018673003/diff/20001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/2018673003/diff/20001/runtime/vm/dart_api_impl.cc#newcode1101 runtime/vm/dart_api_impl.cc:1101: DARTSCOPE(Thread::Current()); thread https://codereview.chromium.org/2018673003/diff/20001/runtime/vm/safepoint.h File runtime/vm/safepoint.h (right): https://codereview.chromium.org/2018673003/diff/20001/runtime/vm/safepoint.h#newcode316 ...
4 years, 6 months ago (2016-05-27 20:08:30 UTC) #3
siva
https://codereview.chromium.org/2018673003/diff/20001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/2018673003/diff/20001/runtime/vm/dart_api_impl.cc#newcode1101 runtime/vm/dart_api_impl.cc:1101: DARTSCOPE(Thread::Current()); On 2016/05/27 20:08:29, rmacnak wrote: > thread Done. ...
4 years, 6 months ago (2016-05-27 20:53:17 UTC) #4
siva
4 years, 6 months ago (2016-05-27 22:30:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
79e4792dd609ef2bb1f66588a912e420bc058709 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698