Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2018673002: Remove unused Skia headers from Blink (Closed)

Created:
4 years, 7 months ago by tomhudson
Modified:
4 years, 7 months ago
Reviewers:
danakj, f(malita)
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, blink-reviews, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused Skia headers from Blink skia/ext/refptr.h is being deprecated, and was no longer used anyway in the files in question. TBR=fmalita@chromium.org BUG=604716, skia:5077 Committed: https://crrev.com/7e34e79b1d047678d872ae73c70d3870fef27693 Cr-Commit-Position: refs/heads/master@{#396352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018673002/1
4 years, 7 months ago (2016-05-26 20:56:12 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-26 20:56:14 UTC) #4
tomhudson
Florin, looks like TBR isn't sufficing here - but I think this is trivial?
4 years, 7 months ago (2016-05-26 20:59:07 UTC) #5
danakj
LGTM
4 years, 7 months ago (2016-05-26 21:20:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018673002/1
4 years, 7 months ago (2016-05-26 21:21:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/28559)
4 years, 7 months ago (2016-05-27 00:53:52 UTC) #11
f(malita)
On 2016/05/26 21:20:34, danakj_OOO_back_5.31 wrote: > LGTM Sorry, OOO LGTM doesn't count :P
4 years, 7 months ago (2016-05-27 01:02:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018673002/1
4 years, 7 months ago (2016-05-27 01:03:46 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-27 02:03:02 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 02:04:18 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e34e79b1d047678d872ae73c70d3870fef27693
Cr-Commit-Position: refs/heads/master@{#396352}

Powered by Google App Engine
This is Rietveld 408576698