Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: content/browser/compositor/gpu_process_transport_factory.cc

Issue 2018603002: Mac: Clean up ifdefs in output surface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate review feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/compositor/gpu_process_transport_factory.cc
diff --git a/content/browser/compositor/gpu_process_transport_factory.cc b/content/browser/compositor/gpu_process_transport_factory.cc
index 2fa3ab536e5570fb6f61d658f519aad8705e8027..3a1416ceb32237e333ca314e5d26fa38ca29e08e 100644
--- a/content/browser/compositor/gpu_process_transport_factory.cc
+++ b/content/browser/compositor/gpu_process_transport_factory.cc
@@ -73,6 +73,7 @@
#include "content/browser/compositor/software_output_device_x11.h"
#elif defined(OS_MACOSX)
#include "components/display_compositor/compositor_overlay_candidate_validator_mac.h"
+#include "content/browser/compositor/gpu_output_surface_mac.h"
#include "content/browser/compositor/software_output_device_mac.h"
#include "gpu/config/gpu_driver_bug_workaround_type.h"
#include "ui/accelerated_widget_mac/window_resize_helper_mac.h"
@@ -453,18 +454,21 @@ void GpuProcessTransportFactory::EstablishedGpuChannel(
std::unique_ptr<
display_compositor::CompositorOverlayCandidateValidator>()));
} else if (capabilities.surfaceless) {
- GLenum target = GL_TEXTURE_2D;
- GLenum format = GL_RGB;
#if defined(OS_MACOSX)
- target = GL_TEXTURE_RECTANGLE_ARB;
- format = GL_RGBA;
-#endif
+ surface = base::WrapUnique(new GpuOutputSurfaceMac(
+ context_provider, data->surface_handle, compositor->vsync_manager(),
+ compositor->task_runner().get(),
+ CreateOverlayCandidateValidator(compositor->widget()),
+ BrowserGpuMemoryBufferManager::current()));
+#else
surface =
base::WrapUnique(new GpuSurfacelessBrowserCompositorOutputSurface(
context_provider, data->surface_handle,
compositor->vsync_manager(), compositor->task_runner().get(),
- CreateOverlayCandidateValidator(compositor->widget()), target,
- format, BrowserGpuMemoryBufferManager::current()));
+ CreateOverlayCandidateValidator(compositor->widget()),
+ GL_TEXTURE_2D, GL_RGB,
+ BrowserGpuMemoryBufferManager::current()));
+#endif
} else {
std::unique_ptr<display_compositor::CompositorOverlayCandidateValidator>
validator;

Powered by Google App Engine
This is Rietveld 408576698