content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h - Issue 2018603002: Mac: Clean up ifdefs in output surface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

Issue 2018603002: Mac: Clean up ifdefs in output surface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate review feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/compositor/gpu_output_surface_mac.mm ('K') | « content/browser/compositor/gpu_process_transport_factory.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

diff --git a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

index a5233033c9e488827f4f56fa94ae4f520dbbf7eb..5fe9af7760039509585ef5b7e6333c10f62be774 100644

--- a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

+++ b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h

@@ -36,7 +36,7 @@ class GpuSurfacelessBrowserCompositorOutputSurface

gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager);

~GpuSurfacelessBrowserCompositorOutputSurface() override;

- private:

+ protected:

danakj 2016/06/01 18:11:04 can you leave the member variables protected? i'm

danakj 2016/06/01 18:11:22 i mean, private.

ccameron 2016/06/01 19:44:22 Yeah, didn't make sense to me. Moved the private d

// cc::OutputSurface implementation.

void SwapBuffers(cc::CompositorFrame* frame) override;

void OnSwapBuffersComplete() override;