Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2018583002: Simple Cache: sync disk cache perftests carefully. (Closed)

Created:
4 years, 6 months ago by gavinp
Modified:
4 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, kinuko+cache_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simple Cache: sync disk cache perftests carefully. The simple cache in particular requires very cautious sync to ensure prior operations are completed. Existing tests are more stable, particularly on windows if we do this. R=rdsmith@chromium.org BUG=611464 Committed: https://crrev.com/6a121fdb06ebe1ccb9bf2233404a25c8559587ec Cr-Commit-Position: refs/heads/master@{#396272}

Patch Set 1 #

Patch Set 2 : add sync back #

Total comments: 6

Patch Set 3 : be (more|less) superstitious as appropriate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M net/disk_cache/disk_cache_perftest.cc View 1 2 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
gavinp
rdsmith: PTAL
4 years, 6 months ago (2016-05-26 16:35:50 UTC) #1
Randy Smith (Not in Mondays)
This is clearly an improvement over what's there, so: LGTM. But I'd be interested in ...
4 years, 6 months ago (2016-05-26 18:26:26 UTC) #2
gavinp
Thanks. I'm making a second upload per your suggestions. https://codereview.chromium.org/2018583002/diff/20001/net/disk_cache/disk_cache_perftest.cc File net/disk_cache/disk_cache_perftest.cc (right): https://codereview.chromium.org/2018583002/diff/20001/net/disk_cache/disk_cache_perftest.cc#newcode239 net/disk_cache/disk_cache_perftest.cc:239: ...
4 years, 6 months ago (2016-05-26 19:03:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018583002/40001
4 years, 6 months ago (2016-05-26 19:06:49 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-26 20:34:41 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 20:36:12 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6a121fdb06ebe1ccb9bf2233404a25c8559587ec
Cr-Commit-Position: refs/heads/master@{#396272}

Powered by Google App Engine
This is Rietveld 408576698