Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1782)

Unified Diff: build/android/adb_profile_chrome.py

Issue 201853007: [Android] Linting the rest of build/android/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/adb_logcat_printer.py ('k') | build/android/asan_symbolize.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/adb_profile_chrome.py
diff --git a/build/android/adb_profile_chrome.py b/build/android/adb_profile_chrome.py
index 107e4b309ceb5363c8096fdda79ee6c7ae840217..a219bfe2cecdda2978daaf80349da4ca17262862 100755
--- a/build/android/adb_profile_chrome.py
+++ b/build/android/adb_profile_chrome.py
@@ -4,7 +4,6 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import base64
import gzip
import logging
import optparse
@@ -27,13 +26,13 @@ from pylib import pexpect
_TRACE_VIEWER_ROOT = os.path.join(constants.DIR_SOURCE_ROOT,
'third_party', 'trace-viewer')
sys.path.append(_TRACE_VIEWER_ROOT)
-from trace_viewer.build import trace2html
+from trace_viewer.build import trace2html # pylint: disable=F0401
_DEFAULT_CHROME_CATEGORIES = '_DEFAULT_CHROME_CATEGORIES'
def _GetTraceTimestamp():
- return time.strftime('%Y-%m-%d-%H%M%S', time.localtime())
+ return time.strftime('%Y-%m-%d-%H%M%S', time.localtime())
class ChromeTracingController(object):
@@ -117,7 +116,7 @@ class SystraceController(object):
def GetCategories(adb):
return adb.RunShellCommand('atrace --list_categories')
- def StartTracing(self, interval):
+ def StartTracing(self, _):
self._thread = threading.Thread(target=self._CollectData)
self._thread.start()
@@ -363,7 +362,7 @@ def main():
action='store_true')
parser.add_option('-z', '--compress', help='Compress the resulting trace '
'with gzip. ', action='store_true')
- options, args = parser.parse_args()
+ options, _args = parser.parse_args()
if options.trace_cc:
parser.parse_error("""--trace-cc is deprecated.
« no previous file with comments | « build/android/adb_logcat_printer.py ('k') | build/android/asan_symbolize.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698