[Android] Linting the rest of build/android/

build/android/lighttpd_server.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provides a convenient wrapper for spawning a test lighttpd instance.
 
 Usage:
   lighttpd_server PATH_TO_DOC_ROOT
@@ skipping 46 matching lines @@
     self.extra_config_contents = extra_config_contents
     self.config_path = config_path or self._Mktmp('config')
     self.error_log = error_log or self._Mktmp('error_log')
     self.access_log = access_log or self._Mktmp('access_log')
     self.pid_file = self._Mktmp('pid_file')
     self.process = None
 
   def _Mktmp(self, name):
     return os.path.join(self.temp_dir, name)
 
-  def _GetRandomPort(self):
+  @staticmethod
+  def _GetRandomPort():
     # The ports of test server is arranged in constants.py.
     return random.randint(constants.LIGHTTPD_RANDOM_PORT_FIRST,
                           constants.LIGHTTPD_RANDOM_PORT_LAST)
 
   def StartupHttpServer(self):
     """Starts up a http server with specified document root and port."""
     # If we want a specific port, make sure no one else is listening on it.
     if self.fixed_port:
       self._KillProcessListeningOnPort(self.fixed_port)
     while True:
@@ skipping 60 matching lines @@
       # Check for server startup error messages
       ix = self.process.expect([pexpect.TIMEOUT, pexpect.EOF, '.+'],
                                timeout=timeout)
       if ix == 2:  # stdout spew from the server
         server_msg += self.process.match.group(0)
       elif ix == 1:  # EOF -- server has quit so giveup.
         client_error = client_error or 'Server exited'
         break
     return (client_error or 'Timeout', server_msg)
 
-  def _KillProcessListeningOnPort(self, port):
+  @staticmethod
+  def _KillProcessListeningOnPort(port):
     """Checks if there is a process listening on port number |port| and
     terminates it if found.
 
     Args:
       port: Port number to check.
     """
     if subprocess.call(['fuser', '-kv', '%d/tcp' % port]) == 0:
       # Give the process some time to terminate and check that it is gone.
       time.sleep(2)
       assert subprocess.call(['fuser', '-v', '%d/tcp' % port]) != 0, \
           'Unable to kill process listening on port %d.' % port
 
-  def _GetDefaultBaseConfig(self):
+  @staticmethod
+  def _GetDefaultBaseConfig():
     return """server.tag                  = "%(server_tag)s"
 server.modules              = ( "mod_access",
                                 "mod_accesslog",
                                 "mod_alias",
                                 "mod_cgi",
                                 "mod_rewrite" )
 
 # default document root required
 #server.document-root = "."
 
@@ skipping 72 matching lines @@
       raw_input('Server running at http://127.0.0.1:%s -'
                 ' press Enter to exit it.' % server.port)
     else:
       print 'Server exit code:', server.process.exitstatus
   finally:
     server.ShutdownHttpServer()
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))