Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 201853007: [Android] Linting the rest of build/android/ (Closed)

Created:
6 years, 9 months ago by jbudorick
Modified:
6 years, 9 months ago
Reviewers:
craigdh, frankf
CC:
chromium-reviews, klundberg+watch_chromium.org, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Linting the rest of build/android/ BUG=168518 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -49 lines) Patch
M build/android/PRESUBMIT.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/adb_logcat_monitor.py View 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/adb_logcat_printer.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/adb_profile_chrome.py View 4 chunks +4 lines, -5 lines 0 comments Download
M build/android/asan_symbolize.py View 3 chunks +7 lines, -8 lines 0 comments Download
M build/android/bb_run_sharded_steps.py View 2 chunks +1 line, -2 lines 0 comments Download
M build/android/findbugs_diff.py View 3 chunks +2 lines, -3 lines 0 comments Download
M build/android/generate_emma_html.py View 4 chunks +3 lines, -4 lines 0 comments Download
M build/android/host_heartbeat.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/install_emulator_deps.py View 2 chunks +2 lines, -0 lines 0 comments Download
M build/android/lighttpd_server.py View 3 chunks +6 lines, -3 lines 0 comments Download
M build/android/lint/suppress.py View 2 chunks +2 lines, -2 lines 0 comments Download
M build/android/surface_stats.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/symbolize_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/test_runner.py View 10 chunks +12 lines, -13 lines 0 comments Download
M build/android/tombstones.py View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jbudorick
This is the last one, I promise.
6 years, 9 months ago (2014-03-21 00:53:50 UTC) #1
frankf
Thanks for all the cleanup! lgtm
6 years, 9 months ago (2014-03-21 18:06:48 UTC) #2
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 9 months ago (2014-03-21 18:13:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/201853007/1
6 years, 9 months ago (2014-03-21 18:13:55 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 18:17:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-21 18:17:12 UTC) #6
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 9 months ago (2014-03-21 19:19:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/201853007/1
6 years, 9 months ago (2014-03-21 19:20:16 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 19:22:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-21 19:22:32 UTC) #10
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 9 months ago (2014-03-24 14:26:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/201853007/1
6 years, 9 months ago (2014-03-24 14:26:19 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 16:21:46 UTC) #13
Message was sent while issue was closed. 
Change committed as 258948

Powered by Google App Engine
This is Rietveld 408576698