Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 201853004: Make Garden-o-matic at least readable on mobile devices (Closed)

Created:
6 years, 9 months ago by eseidel
Modified:
6 years, 9 months ago
Reviewers:
Dirk Pranke, alecflett, ojan
CC:
blink-reviews, ojan, apavlov, abarth-chromium
Visibility:
Public.

Description

Make Garden-o-matic at least readable on mobile devices It still doesn't work very well, but you can at least check the status of the tree and sorta navigate around. BUG=354543 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169710

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix combinators #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -39 lines) Patch
M Tools/GardeningServer/garden-o-matic.html View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/GardeningServer/scripts/ui/results.js View 1 chunk +4 lines, -4 lines 0 comments Download
M Tools/GardeningServer/styles/common.css View 2 chunks +2 lines, -0 lines 0 comments Download
M Tools/GardeningServer/styles/failures.css View 1 2 chunks +9 lines, -8 lines 0 comments Download
M Tools/GardeningServer/styles/main.css View 2 chunks +2 lines, -0 lines 0 comments Download
M Tools/GardeningServer/styles/notifications.css View 1 6 chunks +28 lines, -27 lines 0 comments Download
M Tools/GardeningServer/styles/onebar.css View 1 chunk +6 lines, -0 lines 0 comments Download
M Tools/GardeningServer/styles/results.css View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
eseidel
I've pushed this live and you can test it on your phone at garden-o-matic.appspot.com. :)
6 years, 9 months ago (2014-03-20 18:36:50 UTC) #1
ojan
6 years, 9 months ago (2014-03-20 19:44:58 UTC) #2
ojan
lgtm Please fix the box-orient thing before landing. https://codereview.chromium.org/201853004/diff/1/Tools/GardeningServer/styles/notifications.css File Tools/GardeningServer/styles/notifications.css (right): https://codereview.chromium.org/201853004/diff/1/Tools/GardeningServer/styles/notifications.css#newcode64 Tools/GardeningServer/styles/notifications.css:64: box-orient: ...
6 years, 9 months ago (2014-03-20 19:47:27 UTC) #3
eseidel
I actually removed the spaces to agree with other exampls in that file, but I'm ...
6 years, 9 months ago (2014-03-20 19:48:41 UTC) #4
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-20 19:54:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/201853004/20001
6 years, 9 months ago (2014-03-20 19:54:35 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 19:57:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-20 19:57:22 UTC) #8
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-20 20:03:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/201853004/20001
6 years, 9 months ago (2014-03-20 20:03:20 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 20:52:34 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-20 20:52:34 UTC) #12
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-21 00:27:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/201853004/20001
6 years, 9 months ago (2014-03-21 00:27:38 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 01:05:47 UTC) #15
Message was sent while issue was closed.
Change committed as 169710

Powered by Google App Engine
This is Rietveld 408576698