Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2018513002: Plumb unmodified HTTP/2 stream weight value through SPDY framing code. (Closed)

Created:
4 years, 7 months ago by Bence
Modified:
4 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb unmodified HTTP/2 stream weight value through SPDY framing code. Plumb unmodified HTTP/2 stream weight value through SPDY framing code (SpdyHeadersIR and SpdyFramerVisitorInterface::OnHeaders()). This CL lands server changes 116592396 by mpw and 123319972 by bnc. BUG=488484 Committed: https://crrev.com/ee68b9805ec4b55e4c5b70c9af5c063d90400ded Cr-Commit-Position: refs/heads/master@{#396933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -86 lines) Patch
M net/quic/quic_headers_stream.cc View 4 chunks +5 lines, -2 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 7 chunks +8 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/buffered_spdy_framer.h View 4 chunks +4 lines, -3 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/mock_spdy_framer_visitor.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/spdy/spdy_framer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 13 chunks +10 lines, -15 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 2 chunks +20 lines, -20 lines 0 comments Download
M net/spdy/spdy_protocol.h View 2 chunks +3 lines, -4 lines 0 comments Download
M net/spdy/spdy_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M net/tools/flip_server/spdy_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/flip_server/spdy_interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/flip_server/spdy_interface_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 7 months ago (2016-05-26 15:47:44 UTC) #3
Ryan Hamilton
Whoops, sorry, I totallymissed this. LGTM
4 years, 6 months ago (2016-05-31 19:41:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018513002/1
4 years, 6 months ago (2016-05-31 19:43:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 21:26:17 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 21:27:53 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ee68b9805ec4b55e4c5b70c9af5c063d90400ded
Cr-Commit-Position: refs/heads/master@{#396933}

Powered by Google App Engine
This is Rietveld 408576698