Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2018483002: [iOS/GN] Fix compilation of "all" with gn. (Closed)

Created:
4 years, 7 months ago by sdefresne
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS/GN] Fix compilation of "all" with gn. Do not build mojo/edk/system/platform_wrapper_unittest.cc on iOS as it is unsupported and fails with the following error: ../../mojo/edk/system/platform_wrapper_unittest.cc:90:77: error: expected unqualified-id DEFINE_TEST_CLIENT_TEST_WITH_PIPE(ReadPlatformFile, PlatformWrapperTest, h) { BUG=459705 Committed: https://crrev.com/afcecb7fded20e4ec6251562098fc9d2d55e5ed6 Cr-Commit-Position: refs/heads/master@{#397130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/edk/system/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 7 months ago (2016-05-26 10:22:13 UTC) #2
sdefresne
Ping?
4 years, 6 months ago (2016-05-28 12:31:37 UTC) #3
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 6 months ago (2016-06-01 08:12:44 UTC) #5
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-01 12:50:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018483002/1
4 years, 6 months ago (2016-06-01 12:50:49 UTC) #8
Ken Rockot(use gerrit already)
On 2016/06/01 at 12:50:49, commit-bot wrote: > CQ is trying da patch. Follow status at ...
4 years, 6 months ago (2016-06-01 13:14:09 UTC) #9
sdefresne
No I only sent it to you today, I originally sent it to brettw (main ...
4 years, 6 months ago (2016-06-01 13:18:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 13:55:47 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 13:57:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afcecb7fded20e4ec6251562098fc9d2d55e5ed6
Cr-Commit-Position: refs/heads/master@{#397130}

Powered by Google App Engine
This is Rietveld 408576698