Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2018423002:
the sanitizer builders expect d8 to be build. Make that explicit. (Closed)
|
Created:
4 years, 6 months ago by jochen (gone - plz use gerrit) Modified:
4 years, 6 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionthe sanitizer builders expect d8 to be build. Make that explicit.
BUG=609107
R=machenbach@chromium.org,inferno@chromium.org
Committed: https://crrev.com/49968784179c7a724a40c06c16d249c13c4cbad9
Cr-Commit-Position: refs/heads/master@{#397635}
Patch Set 1 #
Messages
Total messages: 24 (9 generated)
lgtm. Whoever is working on the gyp->gn transition right now for the clusterfuzz stuff might need to incorporate this.
inferno@chromium.org changed reviewers: + dpranke@chromium.org
lgtm. +Dirk, for gyp->gn migration fyi in previous comment. Jochen, looks like this is failing on some bots. https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_com... gyp: Undefined variable gcmole in /b/build/slave/mac/build/src/v8/src/d8.gyp -> returned 1 Updating projects from gyp files...
requires v8 side cl: https://codereview.chromium.org/2023783003
On 2016/05/30 13:49:38, jochen wrote: > requires v8 side cl: https://codereview.chromium.org/2023783003 Sounds good, thanks!
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018423002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018423002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018423002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018423002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== the sanitizer builders expect d8 to be build. Make that explicit. BUG=609107 R=machenbach@chromium.org,inferno@chromium.org ========== to ========== the sanitizer builders expect d8 to be build. Make that explicit. BUG=609107 R=machenbach@chromium.org,inferno@chromium.org Committed: https://crrev.com/49968784179c7a724a40c06c16d249c13c4cbad9 Cr-Commit-Position: refs/heads/master@{#397635} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/49968784179c7a724a40c06c16d249c13c4cbad9 Cr-Commit-Position: refs/heads/master@{#397635} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
