Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2018413003: Get rid of a unused parameter from Editor::notifyComponentsOnChangedSelection() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2016-05-31T14:29:49 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 3 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 } 547 }
548 548
549 bool Editor::shouldDeleteRange(const EphemeralRange& range) const 549 bool Editor::shouldDeleteRange(const EphemeralRange& range) const
550 { 550 {
551 if (range.isCollapsed()) 551 if (range.isCollapsed())
552 return false; 552 return false;
553 553
554 return canDeleteRange(range); 554 return canDeleteRange(range);
555 } 555 }
556 556
557 void Editor::notifyComponentsOnChangedSelection(const VisibleSelection& oldSelec tion) 557 void Editor::notifyComponentsOnChangedSelection()
558 { 558 {
559 client().respondToChangedSelection(m_frame, frame().selection().getSelection Type()); 559 client().respondToChangedSelection(m_frame, frame().selection().getSelection Type());
560 setStartNewKillRingSequence(true); 560 setStartNewKillRingSequence(true);
561 } 561 }
562 562
563 void Editor::respondToChangedContents(const VisibleSelection& endingSelection) 563 void Editor::respondToChangedContents(const VisibleSelection& endingSelection)
564 { 564 {
565 if (frame().settings() && frame().settings()->accessibilityEnabled()) { 565 if (frame().settings() && frame().settings()->accessibilityEnabled()) {
566 Node* node = endingSelection.start().anchorNode(); 566 Node* node = endingSelection.start().anchorNode();
567 if (AXObjectCache* cache = frame().document()->existingAXObjectCache()) 567 if (AXObjectCache* cache = frame().document()->existingAXObjectCache())
(...skipping 736 matching lines...) Expand 10 before | Expand all | Expand 10 after
1304 return; 1304 return;
1305 1305
1306 m_areMarkedTextMatchesHighlighted = flag; 1306 m_areMarkedTextMatchesHighlighted = flag;
1307 frame().document()->markers().repaintMarkers(DocumentMarker::TextMatch); 1307 frame().document()->markers().repaintMarkers(DocumentMarker::TextMatch);
1308 } 1308 }
1309 1309
1310 void Editor::respondToChangedSelection(const VisibleSelection& oldSelection, Fra meSelection::SetSelectionOptions options) 1310 void Editor::respondToChangedSelection(const VisibleSelection& oldSelection, Fra meSelection::SetSelectionOptions options)
1311 { 1311 {
1312 spellChecker().respondToChangedSelection(oldSelection, options); 1312 spellChecker().respondToChangedSelection(oldSelection, options);
1313 frame().inputMethodController().cancelCompositionIfSelectionIsInvalid(); 1313 frame().inputMethodController().cancelCompositionIfSelectionIsInvalid();
1314 notifyComponentsOnChangedSelection(oldSelection); 1314 notifyComponentsOnChangedSelection();
1315 } 1315 }
1316 1316
1317 SpellChecker& Editor::spellChecker() const 1317 SpellChecker& Editor::spellChecker() const
1318 { 1318 {
1319 return frame().spellChecker(); 1319 return frame().spellChecker();
1320 } 1320 }
1321 1321
1322 void Editor::toggleOverwriteModeEnabled() 1322 void Editor::toggleOverwriteModeEnabled()
1323 { 1323 {
1324 m_overwriteModeEnabled = !m_overwriteModeEnabled; 1324 m_overwriteModeEnabled = !m_overwriteModeEnabled;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
1369 } 1369 }
1370 1370
1371 DEFINE_TRACE(Editor) 1371 DEFINE_TRACE(Editor)
1372 { 1372 {
1373 visitor->trace(m_frame); 1373 visitor->trace(m_frame);
1374 visitor->trace(m_lastEditCommand); 1374 visitor->trace(m_lastEditCommand);
1375 visitor->trace(m_mark); 1375 visitor->trace(m_mark);
1376 } 1376 }
1377 1377
1378 } // namespace blink 1378 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698