Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 2018413003: Get rid of a unused parameter from Editor::notifyComponentsOnChangedSelection() (Closed)

Created:
4 years, 8 months ago by yosin_UTC9
Modified:
4 years, 8 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of a unused parameter from Editor::notifyComponentsOnChangedSelection() This patch gets rid of a unused parameter from |Editor::notifyComponentsOnChangedSelection()| to simplify source code for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/973fd8c67c85de65eb914cef95b56053029f7247 Cr-Commit-Position: refs/heads/master@{#396797}

Patch Set 1 : 2016-05-31T14:29:49 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL
4 years, 8 months ago (2016-05-31 05:46:46 UTC) #3
yoichio
lgtm
4 years, 8 months ago (2016-05-31 05:50:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018413003/1
4 years, 8 months ago (2016-05-31 06:03:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-05-31 07:17:01 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-05-31 07:18:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/973fd8c67c85de65eb914cef95b56053029f7247
Cr-Commit-Position: refs/heads/master@{#396797}

Powered by Google App Engine
This is Rietveld 408576698