Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2018363004: VM: Add result cid information for recognized methods. (Closed)

Created:
4 years, 6 months ago by Florian Schneider
Modified:
4 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Add result cid information for recognized methods. We already had this for recognized factories. This CL adds a result cid for the remaining recognized methods. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/0ae4ae50331311caeeb67585ac4a0ed88063ca4c

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : clean up #

Total comments: 1

Patch Set 4 : updated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -302 lines) Patch
M runtime/lib/typed_data.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 2 2 chunks +8 lines, -22 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 2 3 5 chunks +294 lines, -261 lines 0 comments Download
M runtime/vm/method_recognizer.cc View 3 chunks +15 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +13 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 6 months ago (2016-05-31 14:13:49 UTC) #2
rmacnak
LGTM https://codereview.chromium.org/2018363004/diff/40001/runtime/vm/method_recognizer.h File runtime/vm/method_recognizer.h (right): https://codereview.chromium.org/2018363004/diff/40001/runtime/vm/method_recognizer.h#newcode12 runtime/vm/method_recognizer.h:12: // (class-name, function-name, recognized enum, fingerprint). ..., result ...
4 years, 6 months ago (2016-05-31 16:51:59 UTC) #3
Florian Schneider
4 years, 6 months ago (2016-06-01 07:42:55 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
0ae4ae50331311caeeb67585ac4a0ed88063ca4c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698