Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp

Issue 2018353002: Avoid downloading unsupported `<source>` types in HTMLPreloadScanner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix CSS preloading issue tests revealed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/html/parser/HTMLPreloadScanner.h" 5 #include "core/html/parser/HTMLPreloadScanner.h"
6 6
7 #include "core/MediaTypeNames.h" 7 #include "core/MediaTypeNames.h"
8 #include "core/css/MediaValuesCached.h" 8 #include "core/css/MediaValuesCached.h"
9 #include "core/fetch/ClientHintsPreferences.h" 9 #include "core/fetch/ClientHintsPreferences.h"
10 #include "core/frame/Settings.h" 10 #include "core/frame/Settings.h"
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 331
332 for (const auto& testCase : testCases) 332 for (const auto& testCase : testCases)
333 test(testCase); 333 test(testCase);
334 } 334 }
335 335
336 TEST_F(HTMLPreloadScannerTest, testPicture) 336 TEST_F(HTMLPreloadScannerTest, testPicture)
337 { 337 {
338 TestCase testCases[] = { 338 TestCase testCases[] = {
339 {"http://example.test", "<picture><source srcset='srcset_bla.gif'><img s rc='bla.gif'></picture>", "srcset_bla.gif", "http://example.test/", Resource::Im age, 0}, 339 {"http://example.test", "<picture><source srcset='srcset_bla.gif'><img s rc='bla.gif'></picture>", "srcset_bla.gif", "http://example.test/", Resource::Im age, 0},
340 {"http://example.test", "<picture><source sizes='50vw' srcset='srcset_bl a.gif'><img src='bla.gif'></picture>", "srcset_bla.gif", "http://example.test/", Resource::Image, 250}, 340 {"http://example.test", "<picture><source sizes='50vw' srcset='srcset_bl a.gif'><img src='bla.gif'></picture>", "srcset_bla.gif", "http://example.test/", Resource::Image, 250},
341 {"http://example.test", "<picture><source sizes='50vw' srcset='srcset_bl a.gif'><img sizes='50w' src='bla.gif'></picture>", "srcset_bla.gif", "http://exa mple.test/", Resource::Image, 250}, 341 {"http://example.test", "<picture><source sizes='50vw' srcset='srcset_bl a.gif'><img sizes='50vw' src='bla.gif'></picture>", "srcset_bla.gif", "http://ex ample.test/", Resource::Image, 250},
342 {"http://example.test", "<picture><source srcset='srcset_bla.gif' sizes= '50vw'><img sizes='50w' src='bla.gif'></picture>", "srcset_bla.gif", "http://exa mple.test/", Resource::Image, 250}, 342 {"http://example.test", "<picture><source srcset='srcset_bla.gif' sizes= '50vw'><img sizes='50vw' src='bla.gif'></picture>", "srcset_bla.gif", "http://ex ample.test/", Resource::Image, 250},
343 {"http://example.test", "<picture><source srcset='srcset_bla.gif'><img s izes='50w' src='bla.gif'></picture>", "srcset_bla.gif", "http://example.test/", Resource::Image, 0}, 343 {"http://example.test", "<picture><source srcset='srcset_bla.gif'><img s izes='50vw' src='bla.gif'></picture>", "srcset_bla.gif", "http://example.test/", Resource::Image, 0},
344 {"http://example.test", "<picture><source media='(max-width: 900px)' src set='srcset_bla.gif'><img sizes='50vw' srcset='bla.gif 500w'></picture>", "srcse t_bla.gif", "http://example.test/", Resource::Image, 0},
345 {"http://example.test", "<picture><source media='(max-width: 400px)' src set='srcset_bla.gif'><img sizes='50vw' srcset='bla.gif 500w'></picture>", "bla.g if", "http://example.test/", Resource::Image, 250},
346 {"http://example.test", "<picture><source type='image/webp' srcset='srcs et_bla.gif'><img sizes='50vw' srcset='bla.gif 500w'></picture>", "srcset_bla.gif ", "http://example.test/", Resource::Image, 0},
347 {"http://example.test", "<picture><source type='image/jp2' srcset='srcse t_bla.gif'><img sizes='50vw' srcset='bla.gif 500w'></picture>", "bla.gif", "http ://example.test/", Resource::Image, 250},
348 {"http://example.test", "<picture><source media='(max-width: 900px)' typ e='image/jp2' srcset='srcset_bla.gif'><img sizes='50vw' srcset='bla.gif 500w'></ picture>", "bla.gif", "http://example.test/", Resource::Image, 250},
349 {"http://example.test", "<picture><source type='image/webp' media='(max- width: 400px)' srcset='srcset_bla.gif'><img sizes='50vw' srcset='bla.gif 500w'>< /picture>", "bla.gif", "http://example.test/", Resource::Image, 250},
350 {"http://example.test", "<picture><source type='image/jp2' media='(max-w idth: 900px)' srcset='srcset_bla.gif'><img sizes='50vw' srcset='bla.gif 500w'></ picture>", "bla.gif", "http://example.test/", Resource::Image, 250},
351 {"http://example.test", "<picture><source media='(max-width: 400px)' typ e='image/webp' srcset='srcset_bla.gif'><img sizes='50vw' srcset='bla.gif 500w'>< /picture>", "bla.gif", "http://example.test/", Resource::Image, 250},
344 }; 352 };
345 353
346 for (const auto& testCase : testCases) 354 for (const auto& testCase : testCases)
347 test(testCase); 355 test(testCase);
348 } 356 }
349 357
350 TEST_F(HTMLPreloadScannerTest, testReferrerPolicy) 358 TEST_F(HTMLPreloadScannerTest, testReferrerPolicy)
351 { 359 {
352 ReferrerPolicyTestCase testCases[] = { 360 ReferrerPolicyTestCase testCases[] = {
353 { "http://example.test", "<img src='bla.gif'/>", "bla.gif", "http://exam ple.test/", Resource::Image, 0, ReferrerPolicyDefault }, 361 { "http://example.test", "<img src='bla.gif'/>", "bla.gif", "http://exam ple.test/", Resource::Image, 0, ReferrerPolicyDefault },
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 {"http://example.test", "<link rel=preload href=bla as=track>", "bla", " http://example.test/", Resource::TextTrack, 0}, 407 {"http://example.test", "<link rel=preload href=bla as=track>", "bla", " http://example.test/", Resource::TextTrack, 0},
400 {"http://example.test", "<link rel=preload href=bla as=image media=\"(ma x-width: 800px)\">", "bla", "http://example.test/", Resource::Image, 0}, 408 {"http://example.test", "<link rel=preload href=bla as=image media=\"(ma x-width: 800px)\">", "bla", "http://example.test/", Resource::Image, 0},
401 {"http://example.test", "<link rel=preload href=bla as=image media=\"(ma x-width: 400px)\">", nullptr, "http://example.test/", Resource::Image, 0}, 409 {"http://example.test", "<link rel=preload href=bla as=image media=\"(ma x-width: 400px)\">", nullptr, "http://example.test/", Resource::Image, 0},
402 }; 410 };
403 411
404 for (const auto& testCase : testCases) 412 for (const auto& testCase : testCases)
405 test(testCase); 413 test(testCase);
406 } 414 }
407 415
408 } // namespace blink 416 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698