Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2018323002:
Update remoting_all to include all remoting targets. (Closed)
|
Created:
4 years, 6 months ago by Sergey Ulanov Modified:
4 years, 6 months ago Reviewers:
Lambros CC:
chromium-reviews, chromoting-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate remoting_all to include all remoting targets.
Added remoting_dev_me2me_host and native_messaging_host which were
previously not compiled by remoting_all
Committed: https://crrev.com/4d9a0b0aae21c7b936ca4b33b34161ae61fdae4e
Cr-Commit-Position: refs/heads/master@{#397119}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Messages
Total messages: 18 (9 generated)
sergeyu@chromium.org changed reviewers: + lambroslambrou@chromium.org
lgtm
The CQ bit was checked by sergeyu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018323002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by sergeyu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lambroslambrou@chromium.org Link to the patchset: https://codereview.chromium.org/2018323002/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018323002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sergeyu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lambroslambrou@chromium.org Link to the patchset: https://codereview.chromium.org/2018323002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018323002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Update remoting_all to include all remoting targets. Added remoting_dev_me2me_host and native_messaging_host which were previously not compiled by remoting_all ========== to ========== Update remoting_all to include all remoting targets. Added remoting_dev_me2me_host and native_messaging_host which were previously not compiled by remoting_all Committed: https://crrev.com/4d9a0b0aae21c7b936ca4b33b34161ae61fdae4e Cr-Commit-Position: refs/heads/master@{#397119} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4d9a0b0aae21c7b936ca4b33b34161ae61fdae4e Cr-Commit-Position: refs/heads/master@{#397119} |
