Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(212)

Issue 2018313003: Typed CSSOM: Rename Skew and SkewTransformComponent to CSSSkew (Closed)

Created:
4 years, 3 months ago by rjwright
Modified:
4 years, 3 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Typed CSSOM: Rename Skew and SkewTransformComponent to CSSSkew Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#cssskew Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159 BUG=610171 Committed: https://crrev.com/ea6426fc1ecb183d7f5d215a266528ffe8807f28 Cr-Commit-Position: refs/heads/master@{#396781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -166 lines) Patch
A + third_party/WebKit/LayoutTests/typedcssom/cssSkew.html View 3 chunks +11 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/skewTransformComponent.html View 1 chunk +0 lines, -61 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSSkew.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSSkew.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSSkew.idl View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/Skew.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/SkewTransformComponent.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/SkewTransformComponent.cpp View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
rjwright
4 years, 3 months ago (2016-05-30 05:59:50 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018313003/1
4 years, 3 months ago (2016-05-30 05:59:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 3 months ago (2016-05-30 07:19:50 UTC) #7
Timothy Loh
lgtm
4 years, 3 months ago (2016-05-31 03:25:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018313003/1
4 years, 3 months ago (2016-05-31 04:06:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-05-31 04:10:57 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-05-31 04:12:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea6426fc1ecb183d7f5d215a266528ffe8807f28
Cr-Commit-Position: refs/heads/master@{#396781}

Powered by Google App Engine
This is Rietveld 408576698