Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2018263002: Change LayerImpl::LayerTreeAsJson to return a std::unique_ptr. (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change LayerImpl::LayerTreeAsJson to return a std::unique_ptr. BUG=581865 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/6223240a13d6b7cf1e28e6f6a16132ceb424df47 Cr-Commit-Position: refs/heads/master@{#396901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M cc/layers/layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/nine_patch_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/nine_patch_layer_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/layers/ui_resource_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/ui_resource_layer_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dcheng
4 years, 6 months ago (2016-05-31 17:34:47 UTC) #3
vmpstr
lgtm, thanks!
4 years, 6 months ago (2016-05-31 17:42:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018263002/1
4 years, 6 months ago (2016-05-31 17:45:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 19:48:16 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 20:44:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6223240a13d6b7cf1e28e6f6a16132ceb424df47
Cr-Commit-Position: refs/heads/master@{#396901}

Powered by Google App Engine
This is Rietveld 408576698