Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: Source/devtools/front_end/TimelineView.js

Issue 201823003: Timeline: fix expansion arrow appearing on rows with no visible children (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/devtools/front_end/TimelinePresentationModel.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1013 matching lines...) Expand 10 before | Expand all | Expand 10 after
1024 this._dataElement.createTextChild(WebInspector.UIString("× %d", pres entationRecord.presentationChildren().length)); 1024 this._dataElement.createTextChild(WebInspector.UIString("× %d", pres entationRecord.presentationChildren().length));
1025 } else { 1025 } else {
1026 var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNode(reco rd, this._linkifier); 1026 var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNode(reco rd, this._linkifier);
1027 if (detailsNode) { 1027 if (detailsNode) {
1028 this._dataElement.appendChild(document.createTextNode("(")); 1028 this._dataElement.appendChild(document.createTextNode("("));
1029 this._dataElement.appendChild(detailsNode); 1029 this._dataElement.appendChild(detailsNode);
1030 this._dataElement.appendChild(document.createTextNode(")")); 1030 this._dataElement.appendChild(document.createTextNode(")"));
1031 } 1031 }
1032 } 1032 }
1033 1033
1034 this._expandArrowElement.classList.toggle("parent", presentationRecord.h asPresentationChildren()); 1034 this._expandArrowElement.classList.toggle("parent", presentationRecord.e xpandable());
1035 this._expandArrowElement.classList.toggle("expanded", !!presentationReco rd.visibleChildrenCount()); 1035 this._expandArrowElement.classList.toggle("expanded", !!presentationReco rd.visibleChildrenCount());
1036 this._record.setListRow(this); 1036 this._record.setListRow(this);
1037 }, 1037 },
1038 1038
1039 highlight: function(regExp, domChanges) 1039 highlight: function(regExp, domChanges)
1040 { 1040 {
1041 var matchInfo = this.element.textContent.match(regExp); 1041 var matchInfo = this.element.textContent.match(regExp);
1042 if (matchInfo) 1042 if (matchInfo)
1043 WebInspector.highlightSearchResult(this.element, matchInfo.index, ma tchInfo[0].length, domChanges); 1043 WebInspector.highlightSearchResult(this.element, matchInfo.index, ma tchInfo[0].length, domChanges);
1044 }, 1044 },
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
1244 this._element.classList.remove("hidden"); 1244 this._element.classList.remove("hidden");
1245 } else 1245 } else
1246 this._element.classList.add("hidden"); 1246 this._element.classList.add("hidden");
1247 }, 1247 },
1248 1248
1249 _dispose: function() 1249 _dispose: function()
1250 { 1250 {
1251 this._element.remove(); 1251 this._element.remove();
1252 } 1252 }
1253 } 1253 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/TimelinePresentationModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698