Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 201823003: Timeline: fix expansion arrow appearing on rows with no visible children (Closed)

Created:
6 years, 9 months ago by caseq
Modified:
6 years, 9 months ago
Reviewers:
pfeldman, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Timeline: fix expansion arrow appearing on rows with no visible children We used to check TimelinePresentationRecord.expandable(), but it was accidrently replaced with hasPresentationChildren(), which is not the same now, since we keep hidden records in the presentation model. R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M Source/devtools/front_end/TimelinePresentationModel.js View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/devtools/front_end/TimelineView.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
caseq
6 years, 9 months ago (2014-03-19 15:12:54 UTC) #1
caseq
6 years, 9 months ago (2014-03-19 15:30:50 UTC) #2
pfeldman
lgtm
6 years, 9 months ago (2014-03-19 16:35:09 UTC) #3
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 9 months ago (2014-03-19 18:03:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/201823003/1
6 years, 9 months ago (2014-03-19 18:03:36 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 18:06:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-19 18:06:19 UTC) #7
caseq
6 years, 9 months ago (2014-03-20 05:45:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r169620 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698