Clear ui::Layer damaged_region_ after commit.

Clear ui::Layer damaged_region_ after commit.

This was only being cleared for ui::Layers with PictureLayers and not
those with TextureLayers, so all frames afterwards would have
unnecessary damage.

BUG=610086
Committed: https://crrev.com/5ab42edc1361fee3b5255dd36bc8663dfb44cb5e
Cr-Commit-Position: refs/heads/master@{#396936}

Committed: https://crrev.com/ac619ac038346cc2ea96c469ab0bcd23bd13d51c
Cr-Commit-Position: refs/heads/master@{#397529}

[jbauman, 2016-05-31 19:36:27]

jbauman@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-05-31 19:53:15]

https://codereview.chromium.org/2018223002/diff/1/ui/compositor/layer.cc
File ui/compositor/layer.cc (right):

https://codereview.chromium.org/2018223002/diff/1/ui/compositor/layer.cc#newc...
ui/compositor/layer.cc:693: paint_region_.Union(damaged_region_);
Do you think we should union only when it's a painting (picture) layer?

https://codereview.chromium.org/2018223002/diff/1/ui/compositor/layer.h
File ui/compositor/layer.h (right):

https://codereview.chromium.org/2018223002/diff/1/ui/compositor/layer.h#newco...
ui/compositor/layer.h:382: const cc::Region* damaged_region_for_testing() const
{
const Region&?

[jbauman, 2016-05-31 21:12:06]

PTAL.

On 2016/05/31 19:53:15, danakj wrote:
> https://codereview.chromium.org/2018223002/diff/1/ui/compositor/layer.cc
> File ui/compositor/layer.cc (right):
> 
>
https://codereview.chromium.org/2018223002/diff/1/ui/compositor/layer.cc#newc...
> ui/compositor/layer.cc:693: paint_region_.Union(damaged_region_);
> Do you think we should union only when it's a painting (picture) layer?

I'm not entirely sure which is best. For this version of the patch I've changed
it to do that.
> 
> https://codereview.chromium.org/2018223002/diff/1/ui/compositor/layer.h
> File ui/compositor/layer.h (right):
> 
>
https://codereview.chromium.org/2018223002/diff/1/ui/compositor/layer.h#newco...
> ui/compositor/layer.h:382: const cc::Region* damaged_region_for_testing()
const
> {
> const Region&?

Done.

[danakj, 2016-05-31 21:14:08]

LGTM

[jbauman, 2016-05-31 21:14:33]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2016-05-31 21:14:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018223002/20001

[commit-bot: I haz the power, 2016-05-31 21:35:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-31 21:36:50]

Description was changed from

==========
Clear ui::Layer damaged_region_ after commit.

This was only being cleared for ui::Layers with PictureLayers and not
those with TextureLayers, so all frames afterwards would have
unnecessary damage.

BUG=610086
==========

to

==========
Clear ui::Layer damaged_region_ after commit.

This was only being cleared for ui::Layers with PictureLayers and not
those with TextureLayers, so all frames afterwards would have
unnecessary damage.

BUG=610086

Committed: https://crrev.com/5ab42edc1361fee3b5255dd36bc8663dfb44cb5e
Cr-Commit-Position: refs/heads/master@{#396936}
==========

[commit-bot: I haz the power, 2016-05-31 21:36:51]

Patchset 2 (id:??) landed as
https://crrev.com/5ab42edc1361fee3b5255dd36bc8663dfb44cb5e
Cr-Commit-Position: refs/heads/master@{#396936}

[Guido Urdaneta, 2016-06-01 08:06:21]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2027953002/ by guidou@chromium.org.

The reason for reverting is: This CL is suspect of breaking Linux Tests bots.

See crbug.com/616387

I will reland if the revert doesn't fix the bots..

[jbauman, 2016-06-02 20:31:15]

Description was changed from

==========
Clear ui::Layer damaged_region_ after commit.

This was only being cleared for ui::Layers with PictureLayers and not
those with TextureLayers, so all frames afterwards would have
unnecessary damage.

BUG=610086

Committed: https://crrev.com/5ab42edc1361fee3b5255dd36bc8663dfb44cb5e
Cr-Commit-Position: refs/heads/master@{#396936}
==========

to

==========
Clear ui::Layer damaged_region_ after commit.

This was only being cleared for ui::Layers with PictureLayers and not
those with TextureLayers, so all frames afterwards would have
unnecessary damage.

BUG=610086

Committed: https://crrev.com/5ab42edc1361fee3b5255dd36bc8663dfb44cb5e
Cr-Commit-Position: refs/heads/master@{#396936}
==========

[jbauman, 2016-06-02 20:31:30]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2016-06-02 20:31:30]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2018223002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-06-02 20:32:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018223002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018223002/40001

[commit-bot: I haz the power, 2016-06-02 22:22:21]

Description was changed from

==========
Clear ui::Layer damaged_region_ after commit.

This was only being cleared for ui::Layers with PictureLayers and not
those with TextureLayers, so all frames afterwards would have
unnecessary damage.

BUG=610086

Committed: https://crrev.com/5ab42edc1361fee3b5255dd36bc8663dfb44cb5e
Cr-Commit-Position: refs/heads/master@{#396936}
==========

to

==========
Clear ui::Layer damaged_region_ after commit.

This was only being cleared for ui::Layers with PictureLayers and not
those with TextureLayers, so all frames afterwards would have
unnecessary damage.

BUG=610086

Committed: https://crrev.com/5ab42edc1361fee3b5255dd36bc8663dfb44cb5e
Cr-Commit-Position: refs/heads/master@{#396936}
==========

[commit-bot: I haz the power, 2016-06-02 22:22:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-02 22:24:25]

Description was changed from

==========
Clear ui::Layer damaged_region_ after commit.

This was only being cleared for ui::Layers with PictureLayers and not
those with TextureLayers, so all frames afterwards would have
unnecessary damage.

BUG=610086

Committed: https://crrev.com/5ab42edc1361fee3b5255dd36bc8663dfb44cb5e
Cr-Commit-Position: refs/heads/master@{#396936}
==========

to

==========
Clear ui::Layer damaged_region_ after commit.

This was only being cleared for ui::Layers with PictureLayers and not
those with TextureLayers, so all frames afterwards would have
unnecessary damage.

BUG=610086

Committed: https://crrev.com/5ab42edc1361fee3b5255dd36bc8663dfb44cb5e
Cr-Commit-Position: refs/heads/master@{#396936}

Committed: https://crrev.com/ac619ac038346cc2ea96c469ab0bcd23bd13d51c
Cr-Commit-Position: refs/heads/master@{#397529}
==========

[commit-bot: I haz the power, 2016-06-02 22:24:26]

Patchset 3 (id:??) landed as
https://crrev.com/ac619ac038346cc2ea96c469ab0bcd23bd13d51c
Cr-Commit-Position: refs/heads/master@{#397529}