PaymentRequest integration test for dynamic shipping

PaymentRequest integration test for dynamic shipping

Tests that the UI prompts the user to select a shipping address, if the
merchant requires the shipping address to calculate the shipping price.

BUG=608223
Committed: https://crrev.com/42327e1350a6dfad908a708676857c4b37ecd69f
Cr-Commit-Position: refs/heads/master@{#396661}

[please use gerrit instead, 2016-05-27 23:40:13]

Description was changed from

==========
PaymentRequest integration test for dynamic shipping

Tests that the user is unable to click [PAY] button before selecting a
shipping address, if the merchant requires the shipping address to
calculate the shipping price.

BUG=608223
==========

to

==========
PaymentRequest integration test for dynamic shipping

Tests that the UI prompts the user to select a shipping address, if the
merchant requires the shipping address to calculate the shipping price.

BUG=608223
==========

[please use gerrit instead, 2016-05-27 23:42:32]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-05-27 23:42:32]

dfalcantara@, ptal.

[gone, 2016-05-27 23:47:29]

https://codereview.chromium.org/2018203002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
(right):

https://codereview.chromium.org/2018203002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:109:
return ((TextView) mUI.getShippingAddressSectionForTest().findViewById(
I think you'll actually be able to get by just by doing
mUI.getDialogForTest().findViewById(R.id.payments_left_summary_left)

That'd avoid having to add the getShippingAddressSectionForTest() function.

[please use gerrit instead, 2016-05-28 05:29:12]

https://codereview.chromium.org/2018203002/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
(right):

https://codereview.chromium.org/2018203002/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java:109:
return ((TextView) mUI.getShippingAddressSectionForTest().findViewById(
On 2016/05/27 23:47:29, dfalcantara wrote:
> I think you'll actually be able to get by just by doing
> mUI.getDialogForTest().findViewById(R.id.payments_left_summary_left)
> 
> That'd avoid having to add the getShippingAddressSectionForTest() function.

I was under the impression that every section will have a "left summary label",
so the one returned from getDialogForTest().findViewById() may be wrong?

[gone, 2016-05-28 23:46:27]

Nope, you're quite right.  Forgot there were multiple sections in play :/

lgtm

[please use gerrit instead, 2016-05-29 04:54:53]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-05-29 04:54:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018203002/1

[commit-bot: I haz the power, 2016-05-29 07:37:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-29 07:37:06]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[please use gerrit instead, 2016-05-29 19:12:42]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-05-29 19:12:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018203002/1

[commit-bot: I haz the power, 2016-05-29 21:21:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-29 21:23:03]

Description was changed from

==========
PaymentRequest integration test for dynamic shipping

Tests that the UI prompts the user to select a shipping address, if the
merchant requires the shipping address to calculate the shipping price.

BUG=608223
==========

to

==========
PaymentRequest integration test for dynamic shipping

Tests that the UI prompts the user to select a shipping address, if the
merchant requires the shipping address to calculate the shipping price.

BUG=608223

Committed: https://crrev.com/42327e1350a6dfad908a708676857c4b37ecd69f
Cr-Commit-Position: refs/heads/master@{#396661}
==========

[commit-bot: I haz the power, 2016-05-29 21:23:04]

Patchset 1 (id:??) landed as
https://crrev.com/42327e1350a6dfad908a708676857c4b37ecd69f
Cr-Commit-Position: refs/heads/master@{#396661}