Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2263)

Unified Diff: build/common.gypi

Issue 20182002: Make inttypes.h and similar macro usage C++11-friendly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: line Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/scheduler/scheduler_state_machine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index a21d812bf56d464ae352b7738711f626611fa647..62aa480bd3469ca861770dc7b5ad84acceeada2a 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3133,10 +3133,7 @@
# this is worth fixing.
'-Wno-c++11-narrowing',
- # This warns about code like |"0x%08"NACL_PRIxPTR| -- with C++11
- # user-defined literals, this is now a string literal with a UD
- # suffix. However, this is used heavily in NaCl code, so disable
- # the warning for now.
+ # TODO(thakis): Remove, http://crbug.com/263960
'-Wno-reserved-user-defined-literal',
# Clang considers the `register` keyword as deprecated, but e.g.
@@ -3830,10 +3827,7 @@
# this is worth fixing.
'-Wno-c++11-narrowing',
- # This warns about code like |"0x%08"NACL_PRIxPTR| -- with C++11
- # user-defined literals, this is now a string literal with a UD
- # suffix. However, this is used heavily in NaCl code, so disable
- # the warning for now.
+ # TODO(thakis): Remove, http://crbug.com/263960
'-Wno-reserved-user-defined-literal',
# Don't die on dtoa code that uses a char as an array index.
@@ -4141,6 +4135,7 @@
'-Wno-unnamed-type-template-args',
# Match OS X clang C++11 warning settings.
'-Wno-c++11-narrowing',
+ # TODO(thakis): Remove, http://crbug.com/263960
'-Wno-reserved-user-defined-literal',
],
},
« no previous file with comments | « no previous file | cc/scheduler/scheduler_state_machine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698