HTMLVideoElementCapturer: use SkSurface::MakeRaster ISO skia::CreatePlatformCanvas

HTMLVideoElementCapturer: use SkSurface::MakeRaster ISO skia::CreatePlatformCanvas

As explained in the bug, prefer allocating a SkSurface instead
of an expensive PlatformCanvas. Probably cause troubles in
WebKit Win10 bots during landing of another CL, see
https://crrev.com/2010173002

Also re-adding LayoutTest
HTMLMediaElementCapture-capture.html

BUG=615454
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel

Committed: https://crrev.com/277fb015119eb0970ae7bdcb0ec182b881477128
Cr-Commit-Position: refs/heads/master@{#396932}

[mcasas, 2016-05-27 22:01:31]

Description was changed from

==========
HTMLVideoElementCapturer: use SkSurface::MakeRaster ISO
skia::CreatePlatformCanvas

Also adding LayoutTest ...-capture.html

BUG=615454
==========

to

==========
HTMLVideoElementCapturer: use SkSurface::MakeRaster ISO
skia::CreatePlatformCanvas

Also adding LayoutTest ...-capture.html

BUG=615454
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

[mcasas, 2016-05-27 22:04:03]

Description was changed from

==========
HTMLVideoElementCapturer: use SkSurface::MakeRaster ISO
skia::CreatePlatformCanvas

Also adding LayoutTest ...-capture.html

BUG=615454
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

to

==========
HTMLVideoElementCapturer: use SkSurface::MakeRaster ISO
skia::CreatePlatformCanvas

As explained in the bug, prefer allocating a SkSurface instead
of an expensive PlatformCanvas. Probably cause troubles in
WebKit Win10 bots during landing of another CL, see 
https://crrev.com/2010173002

Also re-adding LayoutTest 
HTMLMediaElementCapture-capture.html

BUG=615454
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

[mcasas, 2016-05-27 22:59:03]

mcasas@chromium.org changed reviewers:
+ junov@chromium.org, senorblanco@google.com

[mcasas, 2016-05-27 22:59:04]

junov/senorblanco: PTAL

(junov@ told he might be unavailable).

[Stephen White, 2016-05-31 18:42:43]

senorblanco@chromium.org changed reviewers:
+ senorblanco@chromium.org

[Stephen White, 2016-05-31 18:42:43]

LGTM

https://codereview.chromium.org/2018183002/diff/1/content/renderer/media/html...
File content/renderer/media/html_video_element_capturer_source.cc (right):

https://codereview.chromium.org/2018183002/diff/1/content/renderer/media/html...
content/renderer/media/html_video_element_capturer_source.cc:143: const SkBitmap
bitmap = skia::ReadPixels(canvas);
This may or may not be applicable, but note that now that you have an SkSurface,
you could use SkSurface::makeImageSnapshot() to use Skia's copy-on-write
mechanism, and possibly save yourself a buffer copy.

[mcasas, 2016-05-31 18:49:36]

https://codereview.chromium.org/2018183002/diff/1/content/renderer/media/html...
File content/renderer/media/html_video_element_capturer_source.cc (right):

https://codereview.chromium.org/2018183002/diff/1/content/renderer/media/html...
content/renderer/media/html_video_element_capturer_source.cc:143: const SkBitmap
bitmap = skia::ReadPixels(canvas);
On 2016/05/31 18:42:43, Stephen White wrote:
> This may or may not be applicable, but note that now that you have an
SkSurface,
> you could use SkSurface::makeImageSnapshot() to use Skia's copy-on-write
> mechanism, and possibly save yourself a buffer copy.

Acknowledged. From this side, it'd be always a
read-only copy for the pixel transform below.

[mcasas, 2016-05-31 18:54:44]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-05-31 18:55:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018183002/1

[commit-bot: I haz the power, 2016-05-31 21:15:08]

Description was changed from

==========
HTMLVideoElementCapturer: use SkSurface::MakeRaster ISO
skia::CreatePlatformCanvas

As explained in the bug, prefer allocating a SkSurface instead
of an expensive PlatformCanvas. Probably cause troubles in
WebKit Win10 bots during landing of another CL, see 
https://crrev.com/2010173002

Also re-adding LayoutTest 
HTMLMediaElementCapture-capture.html

BUG=615454
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

to

==========
HTMLVideoElementCapturer: use SkSurface::MakeRaster ISO
skia::CreatePlatformCanvas

As explained in the bug, prefer allocating a SkSurface instead
of an expensive PlatformCanvas. Probably cause troubles in
WebKit Win10 bots during landing of another CL, see 
https://crrev.com/2010173002

Also re-adding LayoutTest 
HTMLMediaElementCapture-capture.html

BUG=615454
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

[commit-bot: I haz the power, 2016-05-31 21:15:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-31 21:16:19]

Description was changed from

==========
HTMLVideoElementCapturer: use SkSurface::MakeRaster ISO
skia::CreatePlatformCanvas

As explained in the bug, prefer allocating a SkSurface instead
of an expensive PlatformCanvas. Probably cause troubles in
WebKit Win10 bots during landing of another CL, see 
https://crrev.com/2010173002

Also re-adding LayoutTest 
HTMLMediaElementCapture-capture.html

BUG=615454
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel
==========

to

==========
HTMLVideoElementCapturer: use SkSurface::MakeRaster ISO
skia::CreatePlatformCanvas

As explained in the bug, prefer allocating a SkSurface instead
of an expensive PlatformCanvas. Probably cause troubles in
WebKit Win10 bots during landing of another CL, see
https://crrev.com/2010173002

Also re-adding LayoutTest
HTMLMediaElementCapture-capture.html

BUG=615454
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,mac_blink_rel,win_blink_rel

Committed: https://crrev.com/277fb015119eb0970ae7bdcb0ec182b881477128
Cr-Commit-Position: refs/heads/master@{#396932}
==========

[commit-bot: I haz the power, 2016-05-31 21:16:21]

Patchset 1 (id:??) landed as
https://crrev.com/277fb015119eb0970ae7bdcb0ec182b881477128
Cr-Commit-Position: refs/heads/master@{#396932}