Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2018133002: Clean up PaymentRequest integration tests. (Closed)

Created:
4 years, 6 months ago by please use gerrit instead
Modified:
4 years, 6 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up PaymentRequest integration tests. In this patch: - JavaScript and CSS is split from HTML. - License headers for the test files. - Linted JavaScript to follow Google style guide. BUG=608223 Committed: https://crrev.com/9b04a1f5bac1a74eceb16c4962af551dfca451aa Cr-Commit-Position: refs/heads/master@{#396576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -100 lines) Patch
A chrome/test/data/android/payments/free_shipping.js View 1 chunk +50 lines, -0 lines 0 comments Download
A chrome/test/data/android/payments/no_shipping.js View 1 chunk +39 lines, -0 lines 0 comments Download
M chrome/test/data/android/payments/payment_request_free_shipping_test.html View 1 chunk +9 lines, -63 lines 0 comments Download
M chrome/test/data/android/payments/payment_request_no_shipping_test.html View 1 chunk +9 lines, -37 lines 0 comments Download
A + chrome/test/data/android/payments/style.css View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/data/android/payments/util.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
please use gerrit instead
dfalcantara@, ptal.
4 years, 6 months ago (2016-05-27 20:26:44 UTC) #2
gone
lgtm
4 years, 6 months ago (2016-05-27 21:35:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2018133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2018133002/1
4 years, 6 months ago (2016-05-27 21:48:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 21:55:39 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 21:57:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b04a1f5bac1a74eceb16c4962af551dfca451aa
Cr-Commit-Position: refs/heads/master@{#396576}

Powered by Google App Engine
This is Rietveld 408576698