Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1734)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2018113002: Upstream: Do not show the add-to-homescreen/install-native-app infobar for WebAPKs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
index 74d23ae4e3b06f981e184cc3152e90b8138eec6d..3bdd159a09a45342ff5780c65cb21e66e04dc1fd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
@@ -8,6 +8,9 @@ import android.content.Intent;
import org.chromium.base.ContextUtils;
import org.chromium.chrome.browser.ShortcutHelper;
+import org.chromium.chrome.browser.banners.AppBannerManager;
+import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.chrome.browser.tab.TabDelegateFactory;
import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.ui.base.PageTransition;
import org.chromium.webapk.lib.client.WebApkServiceConnectionManager;
@@ -43,6 +46,18 @@ public class WebApkActivity extends WebappActivity {
}
@Override
+ protected TabDelegateFactory createTabDelegateFactory() {
+ return new WebappDelegateFactory(this) {
+ @Override
+ public AppBannerManager createAppBannerManager(Tab tab) {
+ // Do not show app banners for WebAPKs regardless of the current page URL.
+ // A WebAPK can display a page outside of its WebAPK scope if a page within the
+ // WebAPK scope navigates via JavaScript while the WebAPK is in the background.
+ return null;
+ }
+ };
+ }
+
public void onStop() {
super.onStop();
String packageName = getWebappInfo().webApkPackageName();

Powered by Google App Engine
This is Rietveld 408576698