Upstream: Do not show the add-to-homescreen/install-native-app infobar for WebAPKs

chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import android.content.Intent;
 
 import org.chromium.chrome.browser.ShortcutHelper;
+import org.chromium.chrome.browser.banners.AppBannerManager;
+import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.chrome.browser.tab.TabDelegateFactory;
 import org.chromium.content_public.browser.LoadUrlParams;
 import org.chromium.ui.base.PageTransition;
 
 /**
  * An Activity is designed for WebAPKs (native Android apps) and displays a webapp in a nearly
  * UI-less Chrome.
  */
 public class WebApkActivity extends WebappActivity {
     @Override
     protected void onNewIntent(Intent intent) {
@@ skipping 12 matching lines @@
                     new LoadUrlParams(overrideUrl, PageTransition.AUTO_TOPLEVEL));
         }
     }
 
     @Override
     protected void initializeSplashScreenWidgets(final int backgroundColor) {
         // TODO(hanxi): Removes this function and use {@link WebApkActivity}'s implementation
         // when WebAPKs are registered in WebappRegistry.
         initializeSplashScreenWidgets(backgroundColor, null);
     }
+
+    @Override
+    protected TabDelegateFactory createTabDelegateFactory() {
+        return new WebappDelegateFactory(this) {
+            @Override
+            public AppBannerManager createAppBannerManager(Tab tab) {

[gone, 2016/05/31 18:26:55]

Do you not want to show _any_ app banners in WebApks?

[pkotwicz, 2016/05/31 20:14:27]

I am aware of only two types of app banners:
- App banners which show an info bar to add an app shortcut to the homescreen
- App banners which show an info bar to install a native Android app

We do not want to show either. Are there other types of app banners that I do
not know about?

[gone, 2016/05/31 20:28:38]

You're assuming the only app banners shown are for the current web app.  What
about users who end up on other sites that trigger banners?  Are those
unimportant?

[pkotwicz, 2016/05/31 21:59:30]

That's a sticky point. Ideally when a user navigates out of the scope of the
WebAPK they would be punted out of Chrome. That's the intent of
https://codereview.chromium.org/2005053002/ It is easy for a web page to stay
within the WebAPK app but navigate out of the WebAPK scope. An example on how
this can occur is if the WebAPK web page navigates itself to a URL outside of
the WebApk scope while the WebAPK is in the background (via JavaScript)

I am fine if the app banner is not shown in this scenario. What do you think?

[gone, 2016/05/31 22:02:34]

Yeah, I'm fine with that, too.  That needs to be documented somewhere to prevent
it from being filed as a bug, though.  Add a comment here to make it obvious
that it was discussed and that app banners are being explicitly not shown in
WebApks.

+                return null;
+            }
+        };
+    }
 }