Refresh the password bubble if it's open when the second request comes in.

Refresh the password bubble if it's open when the second request comes in (Mac).

The background data is updated if a site decides to save a password via the Credential Manager API. However, the bubble content was intact. That is, if user clicked Save then a different (obsolete) credential was stored.

BUG=603427
Committed: https://crrev.com/355d6281ea88189f7d456c9b81eb3ab9acec25c3
Cr-Commit-Position: refs/heads/master@{#396700}

[vasilii, 2016-05-27 16:37:57]

Description was changed from

==========
Refresh the password bubble if it's open when the second request comes in.

BUG=603427
==========

to

==========
Refresh the password bubble if it's open when the second request comes in (Mac).

The background data is updated if a site decides to save a password via the
Credential Manager API. However, the bubble content was intact. That is, if user
clicked Save then a different (obsolete) credential was stored.

BUG=603427
==========

[vasilii, 2016-05-27 16:37:57]

vasilii@chromium.org changed reviewers:
+ groby@chromium.org

[vasilii, 2016-05-27 16:38:39]

Hi Rachel,

please review the CL.

[vasilii, 2016-05-30 08:27:15]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2016-05-30 08:27:16]

Hi Vaclav,

please review the CL.

[vabr (Chromium), 2016-05-30 08:36:41]

lgtm

https://codereview.chromium.org/2018013002/diff/1/chrome/browser/ui/cocoa/pas...
File chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.mm (right):

https://codereview.chromium.org/2018013002/diff/1/chrome/browser/ui/cocoa/pas...
chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.mm:106: // The bubble
is currently shown it should be reopened with the new content.
nit: Split the sentence between "shown it"?
...currently shown. It should ...

[vasilii, 2016-05-30 08:43:02]

https://codereview.chromium.org/2018013002/diff/1/chrome/browser/ui/cocoa/pas...
File chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.mm (right):

https://codereview.chromium.org/2018013002/diff/1/chrome/browser/ui/cocoa/pas...
chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.mm:106: // The bubble
is currently shown it should be reopened with the new content.
On 2016/05/30 08:36:41, vabr (Chromium) wrote:
> nit: Split the sentence between "shown it"?
> ...currently shown. It should ...

Done.

[vasilii, 2016-05-30 08:43:07]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2016-05-30 08:43:08]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2018013002/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2016-05-30 08:43:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018013002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018013002/20001

[commit-bot: I haz the power, 2016-05-30 09:28:00]

Description was changed from

==========
Refresh the password bubble if it's open when the second request comes in (Mac).

The background data is updated if a site decides to save a password via the
Credential Manager API. However, the bubble content was intact. That is, if user
clicked Save then a different (obsolete) credential was stored.

BUG=603427
==========

to

==========
Refresh the password bubble if it's open when the second request comes in (Mac).

The background data is updated if a site decides to save a password via the
Credential Manager API. However, the bubble content was intact. That is, if user
clicked Save then a different (obsolete) credential was stored.

BUG=603427
==========

[commit-bot: I haz the power, 2016-05-30 09:28:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-30 09:29:03]

Description was changed from

==========
Refresh the password bubble if it's open when the second request comes in (Mac).

The background data is updated if a site decides to save a password via the
Credential Manager API. However, the bubble content was intact. That is, if user
clicked Save then a different (obsolete) credential was stored.

BUG=603427
==========

to

==========
Refresh the password bubble if it's open when the second request comes in (Mac).

The background data is updated if a site decides to save a password via the
Credential Manager API. However, the bubble content was intact. That is, if user
clicked Save then a different (obsolete) credential was stored.

BUG=603427

Committed: https://crrev.com/355d6281ea88189f7d456c9b81eb3ab9acec25c3
Cr-Commit-Position: refs/heads/master@{#396700}
==========

[commit-bot: I haz the power, 2016-05-30 09:29:04]

Patchset 2 (id:??) landed as
https://crrev.com/355d6281ea88189f7d456c9b81eb3ab9acec25c3
Cr-Commit-Position: refs/heads/master@{#396700}